Skip to content

Fix CodeCoverage Upload #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix CodeCoverage Upload #4188

merged 1 commit into from
Mar 15, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Mar 12, 2024

Description

Looks like recent breaking changes to code coverage caused our uploads to start failing. This PR tries to fix that.

Testing

Automation

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner March 12, 2024 15:47
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (86e08e5) to head (ac21c70).
Report is 62 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4188       +/-   ##
===========================================
- Coverage   87.38%   65.97%   -21.42%     
===========================================
  Files          56       56               
  Lines       16984    15358     -1626     
===========================================
- Hits        14841    10132     -4709     
- Misses       2143     5226     +3083     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks enabled auto-merge (squash) March 12, 2024 16:15
@gaurav2699
Copy link
Contributor

Stress jobs are failing here weirdly.

@nibanks
Copy link
Member Author

nibanks commented Mar 14, 2024

Stress jobs are failing here weirdly.

It's unrelated to this PR. Let's get this PR merged and then we can work through the issues.

@nibanks nibanks merged commit 809ceaa into main Mar 15, 2024
@nibanks nibanks deleted the nibanks/fix-codecov branch March 15, 2024 07:26
masa-koz pushed a commit to masa-koz/msquic that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants