Implement workaround for log.ps1 not working on Lab Linux #4224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
approved these changes
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4224 +/- ##
==========================================
- Coverage 84.65% 83.85% -0.81%
==========================================
Files 56 56
Lines 15358 15358
==========================================
- Hits 13002 12878 -124
- Misses 2356 2480 +124 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier, we merged PRs to always cancel logging prior to each run because we noticed MsQuic was building up residual ETL traces, causing the storage to balloon. This is necessary until we get to dynamic, temporary lab VMs.
However, after merging those PRs, that surfaced an issue with the usage of "sudo" in the Log.ps1 script when we run it in our lab Linux VMs.
This PR makes it so we do the cancellation of logs on Windows systems, to properly garbage collect the residual ETLs, which looks to be a Windows-only issue anyway.
Testing
CI
Documentation
N/A