Skip to content

backport onebranch fixes release 2.4 #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 26, 2025

Conversation

gaurav2699
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

gaurav2699 and others added 6 commits February 27, 2025 00:43
* added oldnames.lib in test files

* conditional for windows check
* Win32 calls will be stdcall

* added quic_api to test and tools

* added QUIC_API to multiple callbacks

* minor change
* Win32 calls will be stdcall

* added quic_api to test and tools

* added QUIC_API to multiple callbacks

* minor change

* added more quic_api
@gaurav2699 gaurav2699 requested a review from nibanks February 26, 2025 19:17
@gaurav2699 gaurav2699 requested a review from a team as a code owner February 26, 2025 19:17
@gaurav2699 gaurav2699 changed the title backport onebranch fixes backport onebranch fixes release 2.4 Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.65%. Comparing base (f283c90) to head (a441e52).
Report is 1 commits behind head on release/2.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.4    #4862      +/-   ##
===============================================
- Coverage        87.32%   86.65%   -0.67%     
===============================================
  Files               56       56              
  Lines            17338    17338              
===============================================
- Hits             15140    15024     -116     
- Misses            2198     2314     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things got brought in when solving the merge conflict that don't need to be there.

@gaurav2699 gaurav2699 merged commit f6fbf35 into release/2.4 Feb 26, 2025
370 of 381 checks passed
@gaurav2699 gaurav2699 deleted the gaurasingh/backport_onebranchfix_release_2_4 branch February 26, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants