-
Notifications
You must be signed in to change notification settings - Fork 561
backport onebranch fixes release 2.4 #4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport onebranch fixes release 2.4 #4862
Conversation
* added oldnames.lib in test files * conditional for windows check
* Win32 calls will be stdcall * added quic_api to test and tools * added QUIC_API to multiple callbacks * minor change
* Win32 calls will be stdcall * added quic_api to test and tools * added QUIC_API to multiple callbacks * minor change * added more quic_api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #4862 +/- ##
===============================================
- Coverage 87.32% 86.65% -0.67%
===============================================
Files 56 56
Lines 17338 17338
===============================================
- Hits 15140 15024 -116
- Misses 2198 2314 +116 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things got brought in when solving the merge conflict that don't need to be there.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?