-
Notifications
You must be signed in to change notification settings - Fork 577
Fix DSCP detection on Windows. Add DSCP support to SecNetPerf #5130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5130 +/- ##
==========================================
- Coverage 87.45% 86.15% -1.30%
==========================================
Files 59 59
Lines 18048 18086 +38
==========================================
- Hits 15783 15582 -201
- Misses 2265 2504 +239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Suggest updating the readme file with help and sample test run data: https://github.com/microsoft/msquic/blob/main/src/perf/readme.md |
Do you plan to fix this up soon? We need to get this into the release/2.5 branch. |
Ah the problem is that, on receive, windows doesn't fetch the IP_TOS field, just ECN, so this test is failing because now it's actually testing DSCP, and we weren't fetching the DSCP values. |
…soft/msquic into anrossi/fix-dscp-detection
* Fix DSCP detection on Windows. Add DSCP support to SecNetPerf * Add TypeOfService/TrafficClass on receive to test DSCP * Don't attempt to receive TOS/TCLASS on Windows Server 2022 * Also mark epoll and raw datapaths as supporting recv DSCP
) (#5164) * Fix DSCP detection on Windows. Add DSCP support to SecNetPerf * Add TypeOfService/TrafficClass on receive to test DSCP * Don't attempt to receive TOS/TCLASS on Windows Server 2022 * Also mark epoll and raw datapaths as supporting recv DSCP
Description
DSCP detection on Windows was incorrect and setting an invalid value, which would always error, causing MsQuic to determine DSCP to not be supported. This change fixes that bug, and also adds support to SecNetPerf to set DSCP on outgoing packets. It also adds support for receiving DSCP to the Windows datapath layers, which enables the DSCP tests to function.
Testing
Updated existing DSCP tests to validate DSCP is getting sent and received as expected.
Documentation
SecNetPerf help text was updated to list the new option.