Bump up resumption ticket version number (Scoped PR) #5131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default - Uplevel server can accept v1 tickets but always issue v2 tickets - V2 resumption ticket has a 64-byte buffer for usage in the near future - Updated ticket tests
csujedihy
reviewed
May 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5131 +/- ##
==========================================
+ Coverage 86.05% 86.79% +0.73%
==========================================
Files 59 59
Lines 18048 18059 +11
==========================================
+ Hits 15532 15674 +142
+ Misses 2516 2385 -131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anrossi
reviewed
Jun 1, 2025
| @@ -2392,6 +2419,25 @@ QuicCryptoDecodeServerTicket( | |||
| } | |||
| Offset += (uint16_t)TPLength; | |||
|
|
|||
| if (TicketVersion == CXPLAT_TLS_RESUMPTION_TICKET_VERSION_V2) { | |||
| // | |||
| // V2 resumption ticket has a fixed length extension. | |||
There was a problem hiding this comment.
Is the Careful Resume standard close enough to finalization that you know you won't need more space? Or is this a placeholder for future parsing logic?
There was a problem hiding this comment.
I don't think we should take this change until we actually know what should go into the next version of the ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue #5115
Description
Update the version on resumption tickets and added room to include additional data for Careful Resume in the future.
Testing
Updated/added unit tests
Documentation
N/A