Skip to content

Additional settings tests and misc changes #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sm-msft
Copy link
Contributor

@sm-msft sm-msft commented May 30, 2025

This PR includes the settings related test changes from this original draft PR: #5114

Description

  • New Windows user-mode storage API for writing MsQuic test settings
  • Additional settings tests, including tests with stored settings (windows user mode only)
  • Minor build documentation change

Testing

Existing tests + new tests

Documentation

N/A

…r mode only)

- Minor build documentation change
@sm-msft sm-msft requested a review from a team as a code owner May 30, 2025 02:25
@sm-msft
Copy link
Contributor Author

sm-msft commented May 30, 2025

I removed changes that update the last member of QUIC_SETTINGS struct in some macros because it was breaking downlevel tests. There seem to be an implicit contract on the size of this struct in the API - does this need any new documentation?

Original context: https://github.com/microsoft/msquic/pull/5114/files/48f6e9fad9ef371d7f8f3ae34bf53fb30dff14f2#r2113830016

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (cfc5b5e) to head (9111215).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5132      +/-   ##
==========================================
- Coverage   86.05%   86.00%   -0.06%     
==========================================
  Files          59       59              
  Lines       18048    18027      -21     
==========================================
- Hits        15532    15504      -28     
- Misses       2516     2523       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

anrossi added a commit that referenced this pull request May 31, 2025
@sm-msft
Copy link
Contributor Author

sm-msft commented Jun 3, 2025

Discussed Anthony's proposal to move the changes in this PR with #5133 and check them in as part of that PR. This is the plan for now.

anrossi added a commit that referenced this pull request Jun 13, 2025
* Add Writability to Storage Abstraction

* Add tests from #5132

---------

Co-authored-by: Guillaume Hetier <[email protected]>
anrossi added a commit that referenced this pull request Jun 13, 2025
* Add Writability to Storage Abstraction

* Add tests from #5132

---------

Co-authored-by: Guillaume Hetier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants