-
Notifications
You must be signed in to change notification settings - Fork 577
Additional settings tests and misc changes #5132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…r mode only) - Minor build documentation change
I removed changes that update the last member of QUIC_SETTINGS struct in some macros because it was breaking downlevel tests. There seem to be an implicit contract on the size of this struct in the API - does this need any new documentation? Original context: https://github.com/microsoft/msquic/pull/5114/files/48f6e9fad9ef371d7f8f3ae34bf53fb30dff14f2#r2113830016 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5132 +/- ##
==========================================
- Coverage 86.05% 86.00% -0.06%
==========================================
Files 59 59
Lines 18048 18027 -21
==========================================
- Hits 15532 15504 -28
- Misses 2516 2523 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Discussed Anthony's proposal to move the changes in this PR with #5133 and check them in as part of that PR. This is the plan for now. |
* Add Writability to Storage Abstraction * Add tests from #5132 --------- Co-authored-by: Guillaume Hetier <[email protected]>
* Add Writability to Storage Abstraction * Add tests from #5132 --------- Co-authored-by: Guillaume Hetier <[email protected]>
This PR includes the settings related test changes from this original draft PR: #5114
Description
Testing
Existing tests + new tests
Documentation
N/A