Fix react-native-macos-init to not break react-native-windows-init #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
When
react-native-windows-init
modifies a project, it adds areact-native.config.js
file. Whenreact-native-macos-init
modifies a project, it also adds areact-native.config.js
file wiping out any previous contents.This change make it such that the macOS requirements are appended to an existing
react-native.config.js
if one already exists, or creates a new one.react-native-windows-init
creates a config with the contents:react-native-macos-init
will now append:The
react-native-windows-init
package will need a similar change to prepend its required contents toreact-native.config.js
. When it does this, thenreact-native-macos-init
can be run beforereact-native-windows-init
and vis versa.Note: The need for
react-native.config.js
at all in either windows or macOS projects is temporary: when both projects are at react-native 0.62 and react-native-community/cli#1115 lands, then both projects can usenpmPackageName
instead.Focus areas to test
The script was tested against project folder with and without pre-existing
react-native.config.js
files.Microsoft Reviewers: Open in CodeFlow