Skip to content

Should Paper/Fabric components share View Managers? #12753

@TatianaKapos

Description

@TatianaKapos

Summary

Whie creating Fabric components, you need to also register them in Paper Views (when creating new methods or components that Fabric has but Paper doesn't), do we want to separate these or is it more useful to share code between the two?

Motivation

Cleaner code and separation between Fabric and Paper.

For example, currently we have an UnimplentedViewManager that holds Modal properties because Modal doesn't have a Paper-specific view manager. See: https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Views/UnimplementedViewManager.cpp#L62

We also added the size property to Activity Indicator to be handled on the native-side on Fabric and had to add that property to the Paper ActivityIndicatorView Manager here: https://github.com/microsoft/react-native-windows/blob/main/vnext/Microsoft.ReactNative/Views/ActivityIndicatorViewManager.cpp#L26

Basic Example

No response

Open Questions

No response

Metadata

Metadata

Assignees

Labels

Area: Component ViewsNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + FabricWorkstream: Component ParityClose the parity gap between RNW and RN for core RN components and their supporting APIs.enhancement

Projects

Status

No status

Relationships

None yet

Development

No branches or pull requests

Issue actions