Add Support for accessibilityLiveRegion Prop
#13596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
167
to
168
| if (liveRegion == "none"){ | ||
| return LiveSetting::Off; |
There was a problem hiding this comment.
It seems redundant to have this block if the default return value is LiveSetting::Off.
| }else if (liveRegion == "assertive"){ | ||
| return LiveSetting::Assertive; | ||
| } | ||
| //assert(false); // TO-DO: swap to a RedBox error |
There was a problem hiding this comment.
Just curious, what is a RedBox error?
There was a problem hiding this comment.
When you launch a React Native app, it is a kind of error that is shown at runtime in the app window. It helps alert the developer that something in the JavaScript is wrong.
microsoft-github-policy-service
bot
added
Area: Accessibility
Area: ActivityIndicator
Area: Component Views
Area: Fabric
16 tasks
acoates-ms
approved these changes
Aug 27, 2024
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
* Add Tests * Change files * Fix Error * Change files * Format * Update Snapshots * Default to None
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
* Add Tests * Change files * Fix Error * Change files * Format * Update Snapshots * Default to None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Add Support for
accessibilityLiveRegionPropResolves #13031
Resolves #13030
Resolves #13029
Resolves #13028
Resolves #13027
Resolves #13026
Resolves #13025
Resolves #13024
Resolves #12515
What
accessibilityLiveRegionare supportednone,polite, andassertive.accessibilityLiveRegion/aria-live#12515 for behavior of prop.Changelog
Should this change be included in the release notes: Yes
Add Support for
accessibilityLiveRegionPropMicrosoft Reviewers: Open in CodeFlow