Skip to content

.Net: C# package cleanup #10070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
8 of 15 tasks
markwallace-microsoft opened this issue Jan 6, 2025 · 0 comments
Open
8 of 15 tasks

.Net: C# package cleanup #10070

markwallace-microsoft opened this issue Jan 6, 2025 · 0 comments
Assignees
@SergeyMenshykh @markwallace-microsoft
Labels
Build Features planned for next Build conference kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) SK-H2-Planning Issues tagged with this label are listed in SK H2 Planning loop

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 6, 2025 •
edited by SergeyMenshykh
Loading

Review C# package a determine if meta-namespaces can be created to make developer experience similar (anything else)
All non GA packages should have a disposition i.e., graduate, obsolete/replace, redesign
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage kernel Issues or pull requests impacting the core kernel and removed .NET Issue or Pull requests regarding .NET code triage labels Jan 6, 2025
@github-actions github-actions bot changed the title .NET: C# package cleanup .Net: C# package cleanup Jan 6, 2025
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code Build Features planned for next Build conference SK-H2-Planning Issues tagged with this label are listed in SK H2 Planning loop labels Jan 6, 2025
@markwallace-microsoft markwallace-microsoft moved this to Backlog: Planned in Semantic Kernel Jan 13, 2025
@markwallace-microsoft markwallace-microsoft self-assigned this Jan 13, 2025
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Jan 30, 2025
Closed
@SergeyMenshykh SergeyMenshykh moved this from Backlog: Planned to Sprint: In Progress in Semantic Kernel Apr 24, 2025
@SergeyMenshykh SergeyMenshykh mentioned this issue Apr 24, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2025
@SergeyMenshykh
.Net: Graduate Microsoft.SemanticKernel.PromptTemplates.Liquid package (
189e447 
#11716)

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue Apr 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2025
@SergeyMenshykh
.Net: Obsolete SK planners (#11741)
8d18a4e 
### Motivation, Context and Description

This PR stops publishing OpenAI and Handlebars planners as NuGet
packages.

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue Apr 25, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 28, 2025
@SergeyMenshykh
.Net: Remove the experimental attribute from stable openapi api (#11745)
1dd840c 
### Motivation, Context and Description

This PR removes the experimental attribute from the API that was
introduced a while ago and can be considered stable. Additionally, it
enables package validation.

Contributes to:
#10070
This was referenced Apr 30, 2025
Merged
Merged
Open
github-merge-queue bot pushed a commit that referenced this issue May 1, 2025
@SergeyMenshykh
.Net: Remove math and wait plugins (#11815)
426b20e 
### Motivation, Context and Description

Both plugins were introduced a long time ago at the beginning of the
project and are not relevant anymore.

Contributes to:
#10070
github-merge-queue bot pushed a commit that referenced this issue May 1, 2025
@SergeyMenshykh
.Net: Integration tests for the python code interpreter plugin (#11817)
5f54cfb 
### Motivation and Context

This PR adds integration tests for the Python code interpreter plugin.
They are for manual execution only at the moment, which might be
revisited in the future. Additionally, it renames the secret to better
reflect its purpose and describes the way to create and configure the
Azure Container App Session Pool.

Contributes to:
#10070
This was referenced May 2, 2025
Merged
Merged
mccoylstevens pushed a commit to mccoylstevens/semantic-kernel that referenced this issue May 2, 2025
@SergeyMenshykh @mccoylstevens
.Net: Remove math and wait plugins (microsoft#11815)
d40543d 
### Motivation, Context and Description

Both plugins were introduced a long time ago at the beginning of the
project and are not relevant anymore.

Contributes to:
microsoft#10070
mccoylstevens pushed a commit to mccoylstevens/semantic-kernel that referenced this issue May 2, 2025
@SergeyMenshykh @mccoylstevens
.Net: Integration tests for the python code interpreter plugin (micro…
49276f7 
…soft#11817)

### Motivation and Context

This PR adds integration tests for the Python code interpreter plugin.
They are for manual execution only at the moment, which might be
revisited in the future. Additionally, it renames the secret to better
reflect its purpose and describes the way to create and configure the
Azure Container App Session Pool.

Contributes to:
microsoft#10070
github-merge-queue bot pushed a commit that referenced this issue May 2, 2025
@SergeyMenshykh
.Net: Use SendWithSuccessCheck extension methods (#11859)
46e5744 
### Motivation, Context and Description

This PR refactors the `SessionsPythonPlugin` to use the
`SendWithSuccessCheckAsync` extension methods to align the handling of
HTTP requests with the other SK components. Additionally, it fixes minor
logging-related issues and moves a private method down the plugin file
for better readability.

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue May 2, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 2, 2025
@SergeyMenshykh
.Net: Updates to SessionsPythonPlugin (#11872)
e4804d5 
### Motivation, Context and Description

This PR provides control over which domains requests can be sent to.
Additionally, it moves functionality that is common to all operations of
the plugin to one private method to remove duplication.

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue May 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 6, 2025
@SergeyMenshykh
.Net: Add cancellation token & add headers to request (#11900)
3dbfb44 
### Motivation, Context and Description

This PR:
1. Propagates the cancellation token from all kernel functions of the
`SessionsPythonPlugin` plugin down to the APIs they call.
2. Refactors the way the plugin adds headers to the request. Instead of
adding them as default headers of the HTTP client, they are now added as
request headers. The result is the same - the headers are sent each call
of any kernel function of the plugin. This change may save time later by
preventing bug troubleshooting if/when an HTTP client is injected into
the plugin and it sets default headers to the client it does not own.
3. Replaces the usage of HTTP client methods for getting content, such
as `ReadAsStringAsync`, with the SK wrappers
`ReadAsStringWithExceptionMappingAsync` to align the plugin's behavior
with that of other SK components.

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue May 6, 2025
Merged
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Graduate Microsoft.SemanticKernel.PromptTemplates.Liquid package (
0580797 
microsoft#11716)

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Obsolete SK planners (microsoft#11741)
9948625 
### Motivation, Context and Description

This PR stops publishing OpenAI and Handlebars planners as NuGet
packages.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Remove the experimental attribute from stable openapi api (micr…
790e993 
…osoft#11745)

### Motivation, Context and Description

This PR removes the experimental attribute from the API that was
introduced a while ago and can be considered stable. Additionally, it
enables package validation.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Remove math and wait plugins (microsoft#11815)
deacb76 
### Motivation, Context and Description

Both plugins were introduced a long time ago at the beginning of the
project and are not relevant anymore.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Integration tests for the python code interpreter plugin (micro…
b5d5beb 
…soft#11817)

### Motivation and Context

This PR adds integration tests for the Python code interpreter plugin.
They are for manual execution only at the moment, which might be
revisited in the future. Additionally, it renames the secret to better
reflect its purpose and describes the way to create and configure the
Azure Container App Session Pool.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Use SendWithSuccessCheck extension methods (microsoft#11859)
ea0e7cb 
### Motivation, Context and Description

This PR refactors the `SessionsPythonPlugin` to use the
`SendWithSuccessCheckAsync` extension methods to align the handling of
HTTP requests with the other SK components. Additionally, it fixes minor
logging-related issues and moves a private method down the plugin file
for better readability.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Updates to SessionsPythonPlugin (microsoft#11872)
ea8e601 
### Motivation, Context and Description

This PR provides control over which domains requests can be sent to.
Additionally, it moves functionality that is common to all operations of
the plugin to one private method to remove duplication.

Contributes to:
microsoft#10070
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this issue May 6, 2025
@SergeyMenshykh @glorious-beard
.Net: Add cancellation token & add headers to request (microsoft#11900)
dc071c0 
### Motivation, Context and Description

This PR:
1. Propagates the cancellation token from all kernel functions of the
`SessionsPythonPlugin` plugin down to the APIs they call.
2. Refactors the way the plugin adds headers to the request. Instead of
adding them as default headers of the HTTP client, they are now added as
request headers. The result is the same - the headers are sent each call
of any kernel function of the plugin. This change may save time later by
preventing bug troubleshooting if/when an HTTP client is injected into
the plugin and it sets default headers to the client it does not own.
3. Replaces the usage of HTTP client methods for getting content, such
as `ReadAsStringAsync`, with the SK wrappers
`ReadAsStringWithExceptionMappingAsync` to align the plugin's behavior
with that of other SK components.

Contributes to:
microsoft#10070
github-merge-queue bot pushed a commit that referenced this issue May 7, 2025
@SergeyMenshykh
.Net: Remove the experimental attribute from the core plugins (#11906)
acf6b5a 
### Motivation, Context and Description

This PR removes the experimental attribute from the plugins in the
plugins.core package.

Contributes to:
#10070
@SergeyMenshykh SergeyMenshykh mentioned this issue May 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue May 7, 2025
@SergeyMenshykh
.Net: Use type to represent python code execution result (#11931)
fa2d52f 
### Motivation, Context and Description

This PR introduces a new type, `SessionsPythonCodeExecutionResult`, to
represent the Python code execution result and refactors the
`SessionsPythonPlugin.ExecuteCodeAsync` method to return this type
instead of a string. This should allow access to the result in a
structured way for scenarios where the result needs to be processed
further, for example, in the auto function invocation filters. At the
same time, the type overloads the `ToString()` method to be used in
scenarios where the result needs to be a string, for example when the
function is invoked as part of rendering a prompt template.

Contributes to:
#10070
This was referenced May 7, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue May 8, 2025
@SergeyMenshykh
.Net: Graduate Plugins.Core package from 'alpha' to 'preview' (#11950)
b9c0ff3 
Contributes to:
#10070
github-merge-queue bot pushed a commit that referenced this issue May 8, 2025
@SergeyMenshykh
.Net: Remove the Functions.Markdown package (#11951)
faf3c96 
### Motivation, Context and Description

This PR removes the Functions.Markdown project and, as a result, stops
publishing it as a NuGet package. This is part of a clean-up initiative
due to the lack of usage of the package.

Contributes to:
#10070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyMenshykh SergeyMenshykh

@markwallace-microsoft markwallace-microsoft

Labels
Build Features planned for next Build conference kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) SK-H2-Planning Issues tagged with this label are listed in SK H2 Planning loop
Projects
Semantic Kernel
Status: Sprint: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evchaki @SergeyMenshykh @markwallace-microsoft