You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…tion. (#10529)
### Motivation and Context
Fixes#10521
### Description
- Wrap index name in double quotes to handle special characters in
collection names
- Add integration test to verify fix.
- Fix unrelated flaky integration test
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Describe the bug
If the name of the collection contains ‘-’ it will fail to be created, throwing the following exception.
To Reproduce
Execute the following code in a database with the pgvector extension enabled
Expected behavior
Collections can be created successfully even if their name contains ‘-’.
Platform
Additional context
indexName
needs to be wrapped in double quotes.semantic-kernel/dotnet/src/Connectors/Connectors.Memory.Postgres/PostgresVectorStoreCollectionSqlBuilder.cs
Lines 146 to 151 in 892c206
The text was updated successfully, but these errors were encountered: