Java: Implement stubbed memory code #1568
Assignees
Labels
java
Issue or PR regarding Java code
sk team issue
A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Comments
evchaki
added
java
|
As it turns out, the only stubbed code was SemanticTextMemory#merge(MemoryQueryResult). This method was previously marked as deprecated since the method no longer appears in the C# API. This method will be removed as part of this issue. There is a separate issue for unit test coverage (#1598) |
5 tasks
dsgrieve
moved this from Sprint: In Progress
to Sprint: In Review
in Java Semantic Kernel
johnoliver
added a commit
that referenced
this issue
Jun 27, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this issue
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](microsoft#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this issue
Jun 5, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](microsoft#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
johnoliver
added a commit
to microsoft/semantic-kernel-java
that referenced
this issue
Jun 12, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](microsoft/semantic-kernel#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
johnoliver
added a commit
to microsoft/semantic-kernel-java
that referenced
this issue
Jun 12, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](microsoft/semantic-kernel#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
johnoliver
added a commit
to microsoft/semantic-kernel-java
that referenced
this issue
Jun 12, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This method was removed from the C# API. Issue [Java: Implement stubbed memory code](microsoft/semantic-kernel#1568) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Removed method from SemanticTextMemory interface and removed the implementations. There was one use in com.microsoft.semantickernel.planner.sequentialplanner.DefaultSequentialPlannerSKContext#rememberFunctionsAsync which was replaced with a Flux#ignoreElements. This latter change was vetted by @johnoliver ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] ~The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Luigi Montoya <[email protected]> Co-authored-by: joe-braley <[email protected]> Co-authored-by: Luigi96 <[email protected]> Co-authored-by: Mark Wallace <[email protected]> Co-authored-by: John Oliver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: