Skip to content

.Net: output_variable is not a valid property on the YAML schema #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthewbolanos opened this issue Dec 5, 2023 · 0 comments · Fixed by #3965
Closed

.Net: output_variable is not a valid property on the YAML schema #3958

matthewbolanos opened this issue Dec 5, 2023 · 0 comments · Fixed by #3965
Assignees
@markwallace-microsoft
Labels
.NET Issue or Pull requests regarding .NET code

Comments

@matthewbolanos
Copy link
Member

The output_variable should allow the developer to specify the description and output type (just like native functions)
@matthewbolanos matthewbolanos added .NET Issue or Pull requests regarding .NET code v1 bugbash labels Dec 5, 2023
@github-actions github-actions bot changed the title output_variable is not a valid property on the YAML schema .Net: output_variable is not a valid property on the YAML schema Dec 5, 2023
@shawncal shawncal added the triage label Dec 5, 2023
@markwallace-microsoft markwallace-microsoft self-assigned this Dec 5, 2023
@markwallace-microsoft markwallace-microsoft moved this to Sprint: Planned in Semantic Kernel Dec 5, 2023
@markwallace-microsoft markwallace-microsoft moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Dec 5, 2023
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel Dec 5, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
@markwallace-microsoft
.Net: input_parameters should be input_variables to match prompt seri…
737cf8e 
…alization (#3965)

### Motivation and Context

Closes #3953 
Closes #3958 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Dec 5, 2023
Kevdome3000 pushed a commit to Kevdome3000/semantic-kernel that referenced this issue Dec 5, 2023
@markwallace-microsoft @Kevdome3000
.Net: input_parameters should be input_variables to match prompt seri…
9af8415 
…alization (microsoft#3965)

### Motivation and Context

Closes microsoft#3953
Closes microsoft#3958

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

(cherry picked from commit 737cf8e)
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this issue Oct 6, 2024
@markwallace-microsoft
.Net: input_parameters should be input_variables to match prompt seri…
c5506ac 
…alization (microsoft#3965)

### Motivation and Context

Closes microsoft#3953 
Closes microsoft#3958 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
.NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
3 participants
@matthewbolanos @shawncal @markwallace-microsoft