Skip to content

Python: parameters mentioned in a SK prompt are not synced with supplied through config.json #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eavanvalkenburg opened this issue Jun 18, 2024 · 0 comments · Fixed by #6807
Closed

Python: parameters mentioned in a SK prompt are not synced with supplied through config.json #6806

eavanvalkenburg opened this issue Jun 18, 2024 · 0 comments · Fixed by #6807
Assignees
@eavanvalkenburg
Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel

Comments

@eavanvalkenburg
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

When a parameter is mentioned in the prompt multiple times, it is represented in the parameter multiple times as well.

To Reproduce
Steps to reproduce the behavior:
{{$param}}{{$param}}
Will create 2 parameters in the metdata object.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • OS: [e.g. Windows, Mac]
  • IDE: [e.g. Visual Studio, VS Code]
  • Language: [e.g. C#, Python]
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.
@eavanvalkenburg eavanvalkenburg added the bug Something isn't working label Jun 18, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels Jun 18, 2024
@github-actions github-actions bot changed the title Python: parameters mentioned in a SK prompt are not synced with supplied through config.json .Net: Python: parameters mentioned in a SK prompt are not synced with supplied through config.json Jun 18, 2024
@eavanvalkenburg eavanvalkenburg removed the .NET Issue or Pull requests regarding .NET code label Jun 18, 2024
@eavanvalkenburg eavanvalkenburg changed the title .Net: Python: parameters mentioned in a SK prompt are not synced with supplied through config.json Python: parameters mentioned in a SK prompt are not synced with supplied through config.json Jun 18, 2024
@eavanvalkenburg eavanvalkenburg self-assigned this Jun 18, 2024
eavanvalkenburg added a commit to eavanvalkenburg/semantic-kernel that referenced this issue Jun 18, 2024
@eavanvalkenburg
fix for Python: parameters mentioned in a SK prompt are not synced wi…
87f443b 
…th supplied through config.json microsoft#6806
@eavanvalkenburg eavanvalkenburg mentioned this issue Jun 18, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 19, 2024
@eavanvalkenburg
Python: fix for Python: parameters mentioned in a SK prompt are not s…
9f205c3 
…ynced wi… (#6807)

fixes #6806

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this issue Aug 25, 2024
@eavanvalkenburg
Python: fix for Python: parameters mentioned in a SK prompt are not s…
9d6fc90 
…ynced wi… (microsoft#6807)

fixes microsoft#6806

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eavanvalkenburg eavanvalkenburg

Labels
bug Something isn't working python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
2 participants
@eavanvalkenburg @markwallace-microsoft