-
Notifications
You must be signed in to change notification settings - Fork 3.8k
.Net: [Feature Branch] Vector Store Logging #10865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmytrostruk
merged 12 commits into
microsoft:feature-vector-data-telemetry
from
dmytrostruk:vector-store-logging
Mar 12, 2025
Merged
.Net: [Feature Branch] Vector Store Logging #10865
dmytrostruk
merged 12 commits into
microsoft:feature-vector-data-telemetry
from
dmytrostruk:vector-store-logging
Mar 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some documentation updates (I didn't comment everywhere) and the question about adding the same instance twice.
dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/KeywordHybridSearchBuilder.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/KeywordHybridSearchBuilder.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData/VectorSearch/KeywordHybridSearchBuilder.cs
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData/VectorSearch/LoggingKeywordHybridSearchBuilderExtensions.cs
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData/VectorSearch/LoggingVectorizableTextSearchBuilderExtensions.cs
Show resolved
Hide resolved
dotnet/src/Connectors/VectorData/VectorSearch/LoggingVectorizedSearchBuilderExtensions.cs
Show resolved
Hide resolved
westey-m
reviewed
Mar 11, 2025
westey-m
reviewed
Mar 11, 2025
westey-m
reviewed
Mar 11, 2025
westey-m
reviewed
Mar 11, 2025
3fca31f
into
microsoft:feature-vector-data-telemetry
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel.core
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Related: #10596
This PR enhances the vector store functionality by adding builder pattern implementations and logging decorators for key vector data interfaces, along with supporting utilities and DI integration.
Interfaces handled:
IKeywordHybridSearch<TRecord>
IVectorizableTextSearch<TRecord>
IVectorizedSearch<TRecord>
IVectorStore
IVectorStoreRecordCollection<TKey, TRecord>
Class types added:
Use
andBuild
methods.LoggingExtensions
reusable logging methods.AsBuilder
methods to convert service instances into builders.UseLogging
methods to integrate logging into builder pipelines.Add{T}
andAddKeyed{T}
methods for DI registration with configurable lifetimes.Other changes:
Verify
class intoVerify
andKernelVerify
in order to be able to useVerify
methods inMicrosoft.Extensions.VectorData
package without a reference to Semantic Kernel specific logic, likeValidPluginName
,ValidFunctionName
etc.Concepts/Memory
folder.Usage example
Logging with manual registration:
Logging with DI:
Contribution Checklist