Skip to content

Python: Fix agent_id kwarg in AzureAIAgent retrieval sample #11057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

The current AzureAIAgent retrieval sample uses the old assistant_id kwarg to retrieve the agent. We need to fix this to use the new agent_id kwarg in AzureAIAgent retrieval sample

Description

Fix the kwarg to use agent_id.

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner March 19, 2025 01:03
@moonbox3 moonbox3 requested a review from Copilot March 19, 2025 01:03
@moonbox3 moonbox3 self-assigned this Mar 19, 2025
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Mar 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The purpose of the PR is to fix the kwarg usage in the AzureAIAgent retrieval sample by replacing the outdated "assistant_id" with the new "agent_id".

  • Updated the comment and parameter for retrieving the agent in the sample code.
  • Modified the test to reflect the new "agent_id" value instead of "assistant_id".

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
python/samples/getting_started_with_agents/azure_ai_agent/step7_azure_ai_agent_retrieval.py Replaced "assistant_id" with "agent_id" in the agent retrieval and updated comments.
python/tests/unit/agents/azure_ai_agent/test_agent_content_generation.py Updated the test RunStep to use "agent_id" instead of "assistant_id".

@moonbox3 moonbox3 enabled auto-merge March 19, 2025 01:04
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL20883237789% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
3313 5 💤 0 ❌ 0 🔥 1m 41s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into microsoft:main with commit 5cf8568 Mar 20, 2025
30 checks passed
@moonbox3 moonbox3 deleted the fix-azure-ai-agent-sample branch March 20, 2025 00:37
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants