Skip to content

.Net: Update MCP sample with ModelContextProtocol #11121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2025
Merged

.Net: Update MCP sample with ModelContextProtocol #11121

merged 5 commits into from
Mar 25, 2025

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Mar 22, 2025 •
edited by markwallace-microsoft
Loading

@stephentoub stephentoub requested a review from a team as a code owner March 22, 2025 03:03
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core documentation labels Mar 22, 2025
@github-actions github-actions bot changed the title Update MCP sample with ModelContextProtocol .Net: Update MCP sample with ModelContextProtocol Mar 22, 2025
@stephentoub stephentoub mentioned this pull request Mar 23, 2025
Closed
markwallace-microsoft
markwallace-microsoft approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from naming suggestions for @RogerBarreto

markwallace-microsoft
markwallace-microsoft reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unit tests failing, I can re-approve once the PR build is passing.

@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Mar 25, 2025
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Mar 25, 2025
Merged via the queue into microsoft:main with commit c669f74 Mar 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@RogerBarreto RogerBarreto RogerBarreto approved these changes

Assignees
No one assigned
Labels
documentation kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: New Feature: Improve MCP example
4 participants
@stephentoub @RogerBarreto @markwallace-microsoft @SergeyMenshykh