Skip to content

.Net: Merge Tavily feature branch to main #11227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Apr 2, 2025
Merged

.Net: Merge Tavily feature branch to main #11227

merged 19 commits into from
Apr 2, 2025

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Add a TextSearch implementation using the Tavily Search API

  • Initial implementation with search
  • Support for image search
  • Integration tests

Closes #11060

Description

Contribution Checklist

markwallace-microsoft and others added 2 commits March 25, 2025 13:59
@markwallace-microsoft @dmytrostruk
.Net: Initial check-in of the Tavily text search implementation (#11067)
d4cbfa6 
### Motivation and Context

- [x] Implementation of text search
- [x] Unit tests
- [x] Initial getting started samples 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <[email protected]>
@markwallace-microsoft
.Net: Tavily image search and integration tests (#11203)
cb5153c 
### Motivation and Context

- [x] Support for image search
- [x] Enum for search depth
- [x] Integration tests

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner March 27, 2025 07:09
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Mar 27, 2025
@github-actions github-actions bot changed the title Feature tavily .Net: Feature tavily Mar 27, 2025
@markwallace-microsoft markwallace-microsoft changed the title .Net: Feature tavily .Net: Merge Tavily feature branch to main Mar 27, 2025
SergeyMenshykh
SergeyMenshykh previously approved these changes Mar 31, 2025
View reviewed changes
RogerBarreto
RogerBarreto previously approved these changes Apr 1, 2025
View reviewed changes
SergeyMenshykh
SergeyMenshykh previously approved these changes Apr 1, 2025
View reviewed changes
RogerBarreto
RogerBarreto previously approved these changes Apr 1, 2025
View reviewed changes
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@markwallace-microsoft
Copy link
Member Author

Integration tests failed with this error:

[xUnit.net 00:02:33.43]     SemanticKernel.IntegrationTests.Connectors.AzureOpenAI.AzureOpenAIAutoFunctionChoiceBehaviorTests.SpecifiedInPromptInstructsConnectorToInvokeKernelFunctionAutomaticallyAsync [FAIL]
[xUnit.net 00:02:33.43]       Polly.Timeout.TimeoutRejectedException : The operation didn't complete within the allowed timeout of '00:00:30'.

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@markwallace-microsoft
Copy link
Member Author

Integration tests failed with this error:

[xUnit.net 00:02:14.27]     SemanticKernel.IntegrationTests.Connectors.MongoDB.MongoDBKeywordVectorizedHybridSearchTests.SearchWithSkipShouldReturnExpectedResultsAsync [FAIL]
[xUnit.net 00:02:14.27]       Assert.Single() Failure: The collection was empty

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@markwallace-microsoft
Copy link
Member Author

Another failure running integration tests:

[xUnit.net 00:03:49.81]     SemanticKernel.IntegrationTests.Connectors.MongoDB.MongoDBKeywordVectorizedHybridSearchTests.SearchWithTopShouldReturnExpectedResultsAsync [FAIL]
[xUnit.net 00:03:49.81]       Assert.Equal() Failure: Values differ
[xUnit.net 00:03:49.81]       Expected: 2
[xUnit.net 00:03:49.81]       Actual:   3

@markwallace-microsoft markwallace-microsoft merged commit ec1222c into main Apr 2, 2025
20 checks passed
@markwallace-microsoft markwallace-microsoft deleted the feature-tavily branch April 2, 2025 12:24
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
@markwallace-microsoft @dmytrostruk
@RogerBarreto @glorious-beard
.Net: Merge Tavily feature branch to main (microsoft#11227)
1625192 
### Motivation and Context

Add a TextSearch implementation using the Tavily Search API

- [x] Initial implementation with search
- [x] Support for image search
- [x] Integration tests

Closes microsoft#11060 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <[email protected]>
Co-authored-by: Roger Barreto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Add Tavily Text Search
3 participants
@markwallace-microsoft @RogerBarreto @SergeyMenshykh