.Net: Add support for getting notified of all messages and obsolete remaining methods using threadId. #11229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obsolete remaining methods using threadid.
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Mar 27, 2025
alliscode
approved these changes
Mar 27, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
…emaining methods using threadId. (#11229) ### Motivation and Context Some agents currently support returning fully formed messages in a ChatHistory object when invoking with streaming. These invoke methods need to be obsoleted since they are not using `AgentThread`. Moving to a new pattern where we allow an optional `OnNewMessage` callback on options where users can subscribe to all fully formed messages, whether with streaming or without. ### Description - Updated AzureAIAgent, OpenAIAssistantAgent and ChatCompletion agent - Added additional integration tests for this - Updated samples to new pattern ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shethaadit
approved these changes
Mar 27, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
…emaining methods using threadId. (microsoft#11229) ### Motivation and Context Some agents currently support returning fully formed messages in a ChatHistory object when invoking with streaming. These invoke methods need to be obsoleted since they are not using `AgentThread`. Moving to a new pattern where we allow an optional `OnNewMessage` callback on options where users can subscribe to all fully formed messages, whether with streaming or without. ### Description - Updated AzureAIAgent, OpenAIAssistantAgent and ChatCompletion agent - Added additional integration tests for this - Updated samples to new pattern ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some agents currently support returning fully formed messages in a ChatHistory object when invoking with streaming.
These invoke methods need to be obsoleted since they are not using
AgentThread.Moving to a new pattern where we allow an optional
OnNewMessagecallback on options where users can subscribe to all fully formed messages, whether with streaming or without.Description
Contribution Checklist