Skip to content

.Net: Added BraveConnector in WebSearchPlugin #11308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 11, 2025

Conversation

N-E-W-T-O-N
Copy link
Contributor

Motivation and Context

I have Implemented a feature to utilise Brave Search API in web search PLugin

Description

  • Injected Brave search feature in WebKernelBuilderExtensions & WebServiceCollectionExtensions respectively
  • Implemented A class that will call Brave API & handle the response.
  • Added BraveResponse sererlizer class .
  • Override method to return HttpClient with custom HttpMessageHandler in HttpClientProvider.cs

Contribution Checklist

@N-E-W-T-O-N N-E-W-T-O-N requested a review from a team as a code owner April 1, 2025 12:42
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Apr 1, 2025
@github-actions github-actions bot changed the title Added BraveConnector in WebSearchPlugin .Net: Added BraveConnector in WebSearchPlugin Apr 1, 2025
@RogerBarreto
Copy link
Member

@N-E-W-T-O-N Thanks for the new contribution.

Please, add Concepts/Samples, Unit Tests and Integration to this implementations.

Thanks

@N-E-W-T-O-N
Copy link
Contributor Author

@RogerBarreto Added Test Cases .
Please review My PR & let me know of any issue

Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@RogerBarreto RogerBarreto enabled auto-merge April 11, 2025 18:40
@RogerBarreto RogerBarreto added this pull request to the merge queue Apr 11, 2025
Merged via the queue into microsoft:main with commit c4e82f8 Apr 11, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Community PRs to Sprint: Done in Semantic Kernel Apr 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 21, 2025
…#11531)

### Motivation and Context

Added BRAVE SEARCH CAPABILITIES in Semantic Kernel Python based on PR
#11308 .

### Description

- Introduce BraveConnector & BraveSearch for Brave Search API
integration,
- BraveSettings and response models were added, respectively.
- Add unit Tests  

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

3 participants