Skip to content

Python: Add deprecaton warning to add_chat_message for server agents #11331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Apr 2, 2025

Motivation and Context

Now that we have a common agent invocation API, that uses threads, we will be deprecating the add_chat_message for the AzureAIAgent and OpenAIAssistantAgent. Add the deprecation decorator and message.

Description

Add the deprecation decorator and message.

Contribution Checklist

@moonbox3 moonbox3 added the agents label Apr 2, 2025
@moonbox3 moonbox3 self-assigned this Apr 2, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner April 2, 2025 10:39
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 2, 2025
@moonbox3 moonbox3 enabled auto-merge April 2, 2025 10:39
@markwallace-microsoft
Copy link
Member

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/azure_ai
   azure_ai_agent.py1814078%95, 106–116, 121–126, 133–142, 153–159, 210, 212, 218, 229–234, 236, 238, 259–262, 332, 433, 531, 597
semantic_kernel/agents/open_ai
   open_ai_assistant_agent.py2352789%95, 112–113, 121–126, 133–143, 154–160, 317, 330, 366, 532, 636, 737
TOTAL21006247588% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3336 5 💤 0 ❌ 0 🔥 1m 39s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Apr 2, 2025
Merged via the queue into microsoft:main with commit 5d84e10 Apr 2, 2025
32 checks passed
@moonbox3 moonbox3 deleted the add-agent-deprecation-msg branch April 2, 2025 15:56
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Apr 2, 2025
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
…icrosoft#11331)

### Motivation and Context

Now that we have a common agent invocation API, that uses threads, we
will be deprecating the `add_chat_message` for the `AzureAIAgent` and
`OpenAIAssistantAgent`. Add the deprecation decorator and message.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Add the deprecation decorator and message.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants