-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Python: Introducing support for using a MCP server as a plugin #11334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python Test Coverage Report •
Python Unit Test Overview
|
moonbox3
previously approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few small comments.
Is this an extension of the |
It replaces that branch, had some issues with it, was easier to redo from a fresh branch and PR |
b7ddadc
to
52473f1
Compare
nmoeller
reviewed
Apr 3, 2025
alliscode
previously approved these changes
Apr 3, 2025
TaoChenOSU
previously approved these changes
Apr 3, 2025
6d7558e
auto-merge was automatically disabled
April 3, 2025 17:53
Pull Request is not mergeable
With MCP getting more and more popular, i thought it's a cool idea to have plugins loaded and executed remotely with Semantic Kernel. What is included ? - Sample on how to use a MCP Server with Semantic Kernel - New Connector that can read Tools from the MCP Server - The Connector creates a Plugin with the corresponding MCP Tools - Connection can be done via stdio & sse What is **not** included ? - Loading of Resources, Prompts etc. - Handling Authentication to the MCP Server What needs to be done ? - [x] Load MCP Tools as Plugins - [x] Enhance Parameter Parsing between KernelParameters and MCP Tool Parameters - [x] Add Unit Tests - [x] Add Integration Tests <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Eduard van Valkenburg <[email protected]>
TaoChenOSU
approved these changes
Apr 3, 2025
alliscode
approved these changes
Apr 3, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
…soft#11334) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Adds MCP server configs and a function that turns the server into a plugin, with each tools of the server represented as a function. Adds a sample showing how to use that with a Github MCP server. Closes: microsoft#10785 and microsoft#11190 With special thanks to @nmoeller ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Nico Möller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds MCP server configs and a function that turns the server into a plugin, with each tools of the server represented as a function.
Adds a sample showing how to use that with a Github MCP server.
Closes: #10785 and #11190
With special thanks to @nmoeller
Description
Contribution Checklist