Skip to content

.Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings #11336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markwallace-microsoft
Copy link
Member

@markwallace-microsoft markwallace-microsoft commented Apr 2, 2025

Motivation and Context

Closes #11304

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner April 2, 2025 12:20
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Apr 2, 2025
@github-actions github-actions bot changed the title Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings .Net: Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings Apr 2, 2025
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 62533b1 to fabffc2 Compare April 2, 2025 14:29
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 64b6d20 to 1251e9e Compare April 2, 2025 14:55
@markwallace-microsoft markwallace-microsoft changed the title .Net: Add a BoolJsonConverter to handle bool values when converting from PromptExecutionSettings .Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings Apr 2, 2025
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/issue_11304 branch from 1251e9e to 3b50fe7 Compare April 2, 2025 15:10
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@markwallace-microsoft
Copy link
Member Author

markwallace-microsoft commented Apr 17, 2025

Following unit tests failed in integration test pipeline but this looks unrelated to the PR

[xUnit.net 00:00:00.69]     SemanticKernel.Connectors.AzureOpenAI.UnitTests.KernelCore.KernelTests.FunctionUsageMetricsAreCapturedByTelemetryAsExpected [FAIL]
[xUnit.net 00:00:00.69]       Assert.Contains() Failure: Item not found in collection
[xUnit.net 00:00:00.69]       Collection: [55]
[xUnit.net 00:00:00.69]       Not found:  12

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 17, 2025
…PromptExecutionSettings (#11336)

### Motivation and Context

Closes #11304 


### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@markwallace-microsoft
Copy link
Member Author

Another unrelated test failure:

[xUnit.net 00:00:02.36]     SemanticKernel.Functions.UnitTests.OpenApi.Extensions.ApiManifestKernelExtensionsTests.ItCanCreatePluginFromApiManifestWithDescriptionParameterAsync [FAIL]
[xUnit.net 00:00:02.36]       Microsoft.SemanticKernel.HttpOperationException : An error occurred while sending the request.
[xUnit.net 00:00:02.36]       ---- System.Net.Http.HttpRequestException : An error occurred while sending the request.
[xUnit.net 00:00:02.36]       -------- System.IO.IOException : Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
[xUnit.net 00:00:02.36]       ------------ System.Net.Sockets.SocketException : An existing connection was forcibly closed by the remote host.

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
Merged via the queue into microsoft:main with commit 79a29c0 Apr 17, 2025
20 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/issue_11304 branch April 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Bug: CreateFunctionFromPrompty does not deserialise boolean parameter values correctly
5 participants