-
Notifications
You must be signed in to change notification settings - Fork 3.7k
.Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings #11336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markwallace-microsoft
merged 16 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/issue_11304
Apr 17, 2025
Merged
.Net: Add JsonConverter's to handle bool values when converting from PromptExecutionSettings #11336
markwallace-microsoft
merged 16 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/issue_11304
Apr 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omptExecutionSettings
62533b1
to
fabffc2
Compare
64b6d20
to
1251e9e
Compare
1251e9e
to
3b50fe7
Compare
3b50fe7
to
2838ce4
Compare
RogerBarreto
reviewed
Apr 2, 2025
dotnet/src/InternalUtilities/src/Text/OptionalBoolJsonConverter.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/PromptExecutionSettings.cs
Outdated
Show resolved
Hide resolved
…rkwallace-microsoft/semantic-kernel into users/markwallace/issue_11304
3b85499
to
15a1fe9
Compare
RogerBarreto
approved these changes
Apr 15, 2025
833cc6c
to
4fcbb4e
Compare
SergeyMenshykh
approved these changes
Apr 17, 2025
Following unit tests failed in integration test pipeline but this looks unrelated to the PR
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
…PromptExecutionSettings (#11336) ### Motivation and Context Closes #11304 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Another unrelated test failure:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #11304
Description
Contribution Checklist