-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Python: Unit tests for OpenAI realtime and Ollama chat completion #11343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests for OllamaChatCompletion and OpenAIRealtimeWebRTC classes
Python Unit Test Overview
|
TaoChenOSU
reviewed
Apr 2, 2025
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Outdated
Show resolved
Hide resolved
python/tests/unit/connectors/ai/ollama/services/test_ollama_chat_completion.py
Show resolved
Hide resolved
moonbox3
approved these changes
Apr 4, 2025
eavanvalkenburg
approved these changes
Apr 4, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
…crosoft#11343) ### Motivation and Context Improve overall unit test coverage. ### Description adding unit tests for ollama chat completion adding unit tests for openAI realtime ### Contribution Checklist - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Gaudy Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improve overall unit test coverage.
Description
adding unit tests for ollama chat completion
adding unit tests for openAI realtime
Contribution Checklist