Skip to content

Python: Introducing SK as a MCP Server #11362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 11, 2025

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

This PR adds the ability to stand up your Kernel as a MCP Server, it returns the Server object, which you can then run as either a Stdio or Sse server.
Includes a sample to demonstrate.

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner April 3, 2025 15:12
@eavanvalkenburg eavanvalkenburg marked this pull request as draft April 3, 2025 15:12
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Apr 3, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 3, 2025

Python Unit Test Overview

Tests Skipped Failures Errors Time
3419 5 💤 0 ❌ 0 🔥 1m 38s ⏱️

alliscode
alliscode previously approved these changes Apr 3, 2025
@alliscode alliscode self-requested a review April 3, 2025 18:07
@eavanvalkenburg eavanvalkenburg force-pushed the mcp_server branch 2 times, most recently from 08b4216 to d43e28e Compare April 4, 2025 12:04
@eavanvalkenburg eavanvalkenburg marked this pull request as ready for review April 4, 2025 12:15
@SergeyMenshykh
Copy link
Member

The ADR looks good to me.

@eavanvalkenburg eavanvalkenburg requested a review from Copilot April 9, 2025 09:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

python/samples/concepts/mcp/mcp_as_plugin.py:101

  • [nitpick] Consider removing the commented-out block for the deprecated 'Github' plugin to improve code clarity; if kept for historical reasons, add a comment explaining its purpose.
        # MCPStdioPlugin(

python/samples/concepts/mcp/mcp_as_plugin.py:108

  • [nitpick] The plugin name 'everything' may be too vague; consider renaming it to a name that more clearly reflects its role or functionality.
            name="everything",

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • python/.cspell.json: Language not supported

@moonbox3 moonbox3 enabled auto-merge April 10, 2025 07:16
@moonbox3 moonbox3 added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 10, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 11, 2025
Merged via the queue into microsoft:main with commit 78dd3d5 Apr 11, 2025
28 checks passed
@eavanvalkenburg eavanvalkenburg deleted the mcp_server branch April 11, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation modelcontextprotocol python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants