-
Notifications
You must be signed in to change notification settings - Fork 3.7k
.Net: Updates to WebFileDownloadPlugin #11415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markwallace-microsoft
merged 6 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/web_file_download_plugin
Apr 10, 2025
Merged
.Net: Updates to WebFileDownloadPlugin #11415
markwallace-microsoft
merged 6 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/web_file_download_plugin
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9716b07
to
a37662c
Compare
a37662c
to
e5664f8
Compare
e5664f8
to
bd5d9e9
Compare
bd5d9e9
to
645d34f
Compare
dmytrostruk
approved these changes
Apr 7, 2025
…github.com/markwallace-microsoft/semantic-kernel into users/markwallace/web_file_download_plugin
westey-m
reviewed
Apr 10, 2025
westey-m
reviewed
Apr 10, 2025
westey-m
approved these changes
Apr 10, 2025
…github.com/markwallace-microsoft/semantic-kernel into users/markwallace/web_file_download_plugin
westey-m
approved these changes
Apr 10, 2025
Following integration tests failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
AllowedDomains
- Provide control over which domains can be downloaded fromAllowedFolders
- Provide control over which folders can be written toDisableFileOverwrite
- Disable overwriting existing filesMaximumDownloadSize
- Set a maximum size of a download that will be writtenDescription
Contribution Checklist