Skip to content

.Net: Updates to WebFileDownloadPlugin #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

  1. AllowedDomains - Provide control over which domains can be downloaded from
  2. AllowedFolders - Provide control over which folders can be written to
  3. DisableFileOverwrite - Disable overwriting existing files
  4. MaximumDownloadSize - Set a maximum size of a download that will be written

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner April 7, 2025 17:36
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Apr 7, 2025
@github-actions github-actions bot changed the title Updates to WebFileDownloadPlugin .Net: Updates to WebFileDownloadPlugin Apr 7, 2025
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/web_file_download_plugin branch from 9716b07 to a37662c Compare April 7, 2025 17:37
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/web_file_download_plugin branch from a37662c to e5664f8 Compare April 7, 2025 17:39
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/web_file_download_plugin branch from e5664f8 to bd5d9e9 Compare April 7, 2025 17:43
@markwallace-microsoft markwallace-microsoft force-pushed the users/markwallace/web_file_download_plugin branch from bd5d9e9 to 645d34f Compare April 7, 2025 17:47
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@markwallace-microsoft
Copy link
Member Author

Following integration tests failed:

[xUnit.net 01:00:11.42]     MongoDBIntegrationTests.Collections.MongoDBCollectionConformanceTests.CreateCollectionCreatesTheCollection [FAIL]
[xUnit.net 01:00:11.42]       System.TimeoutException : The operation has timed out.
[xUnit.net 01:00:11.42]       Stack Trace:
[xUnit.net 01:00:11.42]         /_/src/Testcontainers/Configurations/WaitStrategies/WaitStrategy.cs(209,0): at DotNet.Testcontainers.Configurations.WaitStrategy.WaitUntilAsync(Func`1 wait, TimeSpan interval, TimeSpan timeout, Int32 retries, CancellationToken ct)
[xUnit.net 01:00:11.43]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.And_within_And [FAIL]
[xUnit.net 01:00:11.43]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchShouldReturnExpectedResultsAsync [FAIL]
[xUnit.net 01:00:11.43]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchWithFilterShouldReturnExpectedResultsAsync [FAIL]
[xUnit.net 01:00:11.42]         /_/src/Testcontainers/Containers/DockerContainer.cs(560,0): at DotNet.Testcontainers.Containers.DockerContainer.CheckReadinessAsync(IEnumerable`1 waitStrategies, CancellationToken ct)
[xUnit.net 01:00:11.43]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Not_over_Or [FAIL]
[xUnit.net 01:00:11.44]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.NotEqual_with_string [FAIL]
[xUnit.net 01:00:11.44]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchWithTopShouldReturnExpectedResultsAsync [FAIL]

[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.GreaterThanOrEqual_with_int [FAIL]
[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchWithSkipShouldReturnExpectedResultsAsync [FAIL]
[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.And [FAIL]
[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchWithMultiTextRecordSearchesRequestedFieldAsync [FAIL]
[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.Collections.MongoDBCollectionConformanceTests.CreateCollectionCalledMoreThanOnceThrowsVectorStoreOperationException [FAIL]
[xUnit.net 01:00:11.45]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Legacy_AnyTagEqualTo_array [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.HybridSearch.MongoDBKeywordVectorizedHybridSearchTests.SearchWithMultipleKeywordsShouldRankMatchedKeywordsHigherAsync [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Equal_with_string_is_not_Contains [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Contains_over_inline_string_array [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Collections.MongoDBCollectionConformanceTests.CreateCollectionIfNotExistsCalledMoreThanOnceDoesNotThrow [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Equal_with_null_captured [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Legacy_AnyTagEqualTo_List [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Collections.MongoDBCollectionConformanceTests.CreateCollectionCalledMoreThanOnceThrowsVectorStoreOperationException_GenericDataModel [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Contains_over_captured_string_array [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.LessThanOrEqual_with_int [FAIL]
[xUnit.net 01:00:11.46]     MongoDBIntegrationTests.Filter.MongoDBBasicFilterTests.Equal_with_string_containing_special_characters [FAIL]


@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 10, 2025
Merged via the queue into microsoft:main with commit 47f921c Apr 10, 2025
22 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/web_file_download_plugin branch April 10, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants