Skip to content

Python: Fix TypeError when required is missing in MCP tool’s inputSchema #11458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Python: Fix TypeError when required is missing in MCP tool’s inputSchema #11458

merged 2 commits into from
Apr 9, 2025

Conversation

KanchiShimono
Copy link
Contributor

Motivation and Context

Resolves #11457

Description

Fixed an issue where a TypeError would occur when the inputSchema of a tool listed from the MCP server did not include any required parameters.

Contribution Checklist

@KanchiShimono KanchiShimono requested a review from a team as a code owner April 9, 2025 03:13
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 9, 2025
@github-actions github-actions bot changed the title Fix TypeError when required is missing in MCP tool’s inputSchema Python: Fix TypeError when required is missing in MCP tool’s inputSchema Apr 9, 2025
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@moonbox3
Copy link
Contributor

moonbox3 commented Apr 9, 2025

Thanks for the fix, @KanchiShimono.

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 9, 2025 •
edited
Loading

Python Unit Test Overview

Tests Skipped Failures Errors Time
3418 5 💤 0 ❌ 0 🔥 1m 39s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
Merged via the queue into microsoft:main with commit 7e376b7 Apr 9, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Bug: MCP plugin raises TypeError for undefined required parameter in MCP tool inputSchema
4 participants
@KanchiShimono @moonbox3 @markwallace-microsoft @eavanvalkenburg