Skip to content

.Net: Use DI to keep prompt, resource, and resource template definitions. #11544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SergeyMenshykh
Copy link
Member

Motivation, Context and Description

This PR removes unnecessary prompt and resource registries that were used to store prompts, resources, and resource template definitions and provide handlers for listing and reading those. As it later appeared, they are not really necessary, and the DI container can be used for keeping those definitions.

@SergeyMenshykh SergeyMenshykh added .NET Issue or Pull requests regarding .NET code modelcontextprotocol labels Apr 14, 2025
@SergeyMenshykh SergeyMenshykh self-assigned this Apr 14, 2025
@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner April 14, 2025 16:41
@SergeyMenshykh SergeyMenshykh moved this to Sprint: In Review in Semantic Kernel Apr 14, 2025
@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Apr 15, 2025
Merged via the queue into microsoft:main with commit 6990277 Apr 15, 2025
20 checks passed
@SergeyMenshykh SergeyMenshykh deleted the di-registration-of-prompts-and-resources branch April 15, 2025 07:07
@github-project-automation github-project-automation bot moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modelcontextprotocol .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

3 participants