Skip to content

.Net: Update GeminiChatMessageContent to support System.Text.Json deserialization when calledToolResult is null #11622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

.Net: Update GeminiChatMessageContent to support System.Text.Json deserialization when calledToolResult is null #11622

merged 4 commits into from
Apr 17, 2025

Conversation

markwallace-microsoft
Copy link
Member

Motivation and Context

Changes from https://github.com/microsoft/semantic-kernel/pull/11236/files

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner April 17, 2025 13:43
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Apr 17, 2025
@github-actions github-actions bot changed the title Update GeminiChatMessageContent to support System.Text.Json deserialization when calledToolResult is null .Net: Update GeminiChatMessageContent to support System.Text.Json deserialization when calledToolResult is null Apr 17, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Apr 17, 2025
Merged via the queue into microsoft:main with commit 04dcf86 Apr 17, 2025
20 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/GeminiChatMessageContent_JsonSer branch April 17, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytrostruk dmytrostruk dmytrostruk approved these changes

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markwallace-microsoft @dmytrostruk @RogerBarreto @SergeyMenshykh