-
Notifications
You must be signed in to change notification settings - Fork 3.8k
.Net: Handle rendering a list of strings in a SK prompt #11780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markwallace-microsoft
merged 5 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/handle_prompt_list_strings
May 6, 2025
Merged
.Net: Handle rendering a list of strings in a SK prompt #11780
markwallace-microsoft
merged 5 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/handle_prompt_list_strings
May 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
reviewed
Apr 28, 2025
dotnet/src/SemanticKernel.Core/PromptTemplate/KernelPromptTemplate.cs
Outdated
Show resolved
Hide resolved
25f11e1
to
f0a72b4
Compare
dotnet/src/SemanticKernel.Core/PromptTemplate/KernelPromptTemplate.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
approved these changes
May 2, 2025
westey-m
approved these changes
May 2, 2025
RogerBarreto
approved these changes
May 6, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
May 6, 2025
) ### Motivation and Context Convert lists of strings to a string value correctly ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Convert lists of strings to a string value correctly
Description
Contribution Checklist