-
Notifications
You must be signed in to change notification settings - Fork 3.8k
.Net: Delete CreateCollection, rename CreateIfNotExists and make EnsureExists thread safe. #11937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
westey-m
merged 10 commits into
microsoft:feature-vector-data-preb3
from
westey-m:mevd-create-collection-changes
May 7, 2025
Merged
.Net: Delete CreateCollection, rename CreateIfNotExists and make EnsureExists thread safe. #11937
westey-m
merged 10 commits into
microsoft:feature-vector-data-preb3
from
westey-m:mevd-create-collection-changes
May 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o mevd-create-collection-changes
4 tasks
…o mevd-create-collection-changes
roji
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor comments, otherwise LGTM!
dotnet/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchCollection.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Redis/RedisHashSetCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Redis/RedisJsonCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Memory.Weaviate/WeaviateCollection.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.Weaviate.UnitTests/WeaviateCollectionTests.cs
Show resolved
Hide resolved
…o mevd-create-collection-changes
b318ae6
into
microsoft:feature-vector-data-preb3
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel
Issues or pull requests impacting the core kernel
memory
needs_port_to_python
Indicate this item needs to also be done for Python
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#11829
Description
Contribution Checklist