Skip to content

.Net: Delete CreateCollection, rename CreateIfNotExists and make EnsureExists thread safe. #11937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented May 7, 2025

Motivation and Context

#11829

Description

  • DeleteCreateCollection
  • Rename CreateCollectionIfNotExists to EnsureCollectionExists
  • Make EnsureCollectionExists thread safe
  • Update tests and samples.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner May 7, 2025 15:43
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation memory labels May 7, 2025
@github-actions github-actions bot changed the title Delete CreateCollection, rename CreateIfNotExists and make EnsureExists thread safe. .Net: Delete CreateCollection, rename CreateIfNotExists and make EnsureExists thread safe. May 7, 2025
@westey-m westey-m added the needs_port_to_python Indicate this item needs to also be done for Python label May 7, 2025
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comments, otherwise LGTM!

@westey-m westey-m merged commit b318ae6 into microsoft:feature-vector-data-preb3 May 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel Issues or pull requests impacting the core kernel memory needs_port_to_python Indicate this item needs to also be done for Python .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants