Skip to content

Python fix native function default parameter #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/semantic_kernel/orchestration/sk_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def from_native_method(method, skill_name="", log=None) -> "SKFunction":
if (
hasattr(method, "__sk_function_input_description__")
and method.__sk_function_input_description__ is not None
and method.__sk_function_input_description__ != ""
):
input_param = ParameterView(
"input",
Expand Down
100 changes: 100 additions & 0 deletions python/tests/unit/orchestration/test_native_function.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
# Copyright (c) Microsoft. All rights reserved.

from semantic_kernel.orchestration.sk_function import SKFunction
from semantic_kernel.skill_definition.sk_function_decorator import sk_function


def test_init_native_function_with_input_description():
class MockMethodWithInputDescription:
__sk_function__ = True
__sk_function_name__ = "mock_function"
__sk_function_description__ = "Mock description"
__sk_function_input_description__ = "Mock input description"
__sk_function_input_default_value__ = "default_input_value"
__sk_function_context_parameters__ = [
{
"name": "param1",
"description": "Param 1 description",
"default_value": "default_param1_value",
}
]

mock_method = MockMethodWithInputDescription

native_function = SKFunction.from_native_method(mock_method, "MockSkill")

assert native_function._function == mock_method
assert native_function._parameters[0].name == "input"
assert native_function._parameters[0].description == "Mock input description"
assert native_function._parameters[0].default_value == "default_input_value"
assert native_function._parameters[1].name == "param1"
assert native_function._parameters[1].description == "Param 1 description"
assert native_function._parameters[1].default_value == "default_param1_value"


def test_init_native_function_without_input_description():
class MockMethodWithoutInputDescription:
__sk_function__ = True
__sk_function_name__ = "mock_function_no_input_desc"
__sk_function_description__ = "Mock description no input desc"
__sk_function_context_parameters__ = [
{
"name": "param1",
"description": "Param 1 description",
"default_value": "default_param1_value",
}
]

mock_method = MockMethodWithoutInputDescription

native_function = SKFunction.from_native_method(mock_method, "MockSkill")

assert native_function._function == mock_method
assert native_function._parameters[0].name == "param1"
assert native_function._parameters[0].description == "Param 1 description"
assert native_function._parameters[0].default_value == "default_param1_value"


def test_init_native_function_from_sk_function_decorator():
@sk_function(
description="Test description",
name="test_function",
input_description="Test input description",
input_default_value="test_default_value",
)
def decorated_function():
pass

assert decorated_function.__sk_function__ is True
assert decorated_function.__sk_function_description__ == "Test description"
assert decorated_function.__sk_function_name__ == "test_function"
assert (
decorated_function.__sk_function_input_description__ == "Test input description"
)
assert (
decorated_function.__sk_function_input_default_value__ == "test_default_value"
)

native_function = SKFunction.from_native_method(decorated_function, "MockSkill")

assert native_function._function == decorated_function
assert native_function._parameters[0].name == "input"
assert native_function._parameters[0].description == "Test input description"
assert native_function._parameters[0].default_value == "test_default_value"


def test_init_native_function_from_sk_function_decorator_defaults():
@sk_function()
def decorated_function():
pass

assert decorated_function.__sk_function__ is True
assert decorated_function.__sk_function_description__ == ""
assert decorated_function.__sk_function_name__ == "decorated_function"
assert decorated_function.__sk_function_input_description__ == ""
assert decorated_function.__sk_function_input_default_value__ == ""

native_function = SKFunction.from_native_method(decorated_function, "MockSkill")

assert native_function._function == decorated_function
assert len(native_function._parameters) == 0