Update InteractWithGraph.tsx - Fix failures caused by break change of stripping off the async suffix from SK functions #2483
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failures caused by break change of stripping off the async suffix from SK functions
freistli
changed the title
teresaqhoang
approved these changes
Aug 21, 2023
|
@freistli We've fixed the failing precheck (Python Integration Tests) on our end, but we cannot update your branch or queue a new build. It looks like you have not yet checked the "Allow edits from maintainers" box that would normally show this on the righth column: Could you please update (merge) the latest changes from main? And, if you see the option, check the "allow edits from maintainers" box in this PR? That will allow us to merge directly into main upon successful checks, or apply further merges if needed. Thanks! |
|
Thanks @shawncal , just merged the main branch in the pull request. I cannot see "allow edits from maintainers" option on my right column. Now the PR status is waiting for OCTO group reviewers' approval. |
shawncal
approved these changes
Aug 22, 2023
|
Awesome, queued for merge. Thanks @freistli for the fix! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
… stripping off the async suffix from SK functions (microsoft#2483) Fix failures caused by break change of stripping off the async suffix from SK functions ### Motivation and Context The auth-api sample doesn't work anymore because of the break change listed in https://github.com/freistli/semantic-kernel/blob/main/docs/decisions/0003-support-multiple-native-function-args.md Updated name selection heuristic to strip off an "Async" suffix for async methods. ### Description KernelServer service reports similar errors the sample is calling: Result: Function 'InvokeFunction', Invocation id '6dcbc5af-9484-4357-a5ac-c91b585dfac5': An exception was thrown by the invocation. Exception: System.AggregateException: One or more errors occurred. (Function not available: Function not available emailskill.getmyemailaddressasync) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failures caused by break change of stripping off the async suffix from SK functions
Motivation and Context
The auth-api sample doesn't work anymore because of the break change listed in https://github.com/freistli/semantic-kernel/blob/main/docs/decisions/0003-support-multiple-native-function-args.md
Updated name selection heuristic to strip off an "Async" suffix for async methods.
Description
KernelServer service reports similar errors the sample is calling:
Result: Function 'InvokeFunction', Invocation id '6dcbc5af-9484-4357-a5ac-c91b585dfac5': An exception was thrown by the invocation.
Exception: System.AggregateException: One or more errors occurred. (Function not available: Function not available emailskill.getmyemailaddressasync)
Contribution Checklist