.Net: refactor : SummarizeConversation #6719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintain consistency in language summarization
github-actions
bot
changed the title
Josephrp
approved these changes
Jun 16, 2024
dmytrostruk
approved these changes
Jun 18, 2024
markwallace-microsoft
approved these changes
Jun 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
Maintain consistency in language summarization
### Motivation and Context
1. Why is this change required?
This change is required to address the issue of inconsistent language
summarization. The previous implementation
defaulted to English summaries regardless of the original language of
the conversation, which could lead to confusion and
loss of meaning.
2. What problem does it solve?
It solves the problem where non-English conversations were incorrectly
summarized in English, leading to potential
misinterpretation of the summarized content.
3. What scenario does it contribute to?
This change contributes to scenarios where users engage in conversations
in various languages and expect summaries in
the same language, enhancing the user experience and accuracy of the
summaries.
4. If it fixes an open issue, please link to the issue here.
### Description
This change contributes to scenarios where users engage in conversations
in various languages and expect summaries in the same language,
enhancing the user experience and accuracy of the summaries.
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain consistency in language summarization
Motivation and Context
This change is required to address the issue of inconsistent language summarization. The previous implementation
defaulted to English summaries regardless of the original language of the conversation, which could lead to confusion and
loss of meaning.
It solves the problem where non-English conversations were incorrectly summarized in English, leading to potential
misinterpretation of the summarized content.
This change contributes to scenarios where users engage in conversations in various languages and expect summaries in
the same language, enhancing the user experience and accuracy of the summaries.
Description
This change contributes to scenarios where users engage in conversations in various languages and expect summaries in the same language, enhancing the user experience and accuracy of the summaries.
Contribution Checklist