Skip to content

Python: custom service selector sample #6802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Jun 18, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jun 18, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL636571889% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1511 1 💤 0 ❌ 0 🔥 18.654s ⏱️

@eavanvalkenburg eavanvalkenburg marked this pull request as ready for review June 18, 2024 12:06
@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner June 18, 2024 12:06
@eavanvalkenburg eavanvalkenburg force-pushed the service_selector_sample branch from 2686c17 to d3cff88 Compare June 18, 2024 14:30
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Jun 18, 2024
Merged via the queue into microsoft:main with commit d30250f Jun 18, 2024
23 checks passed
@eavanvalkenburg eavanvalkenburg deleted the service_selector_sample branch June 18, 2024 15:11
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants