Validate goal and handle plan parsing errors in SequentialPlanner #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemillermicrosoft
changed the title
lemillermicrosoft
added
the
kernel
lemillermicrosoft
force-pushed
the
427_plan_goal_escape
branch
from
54e2149 to
b1ebc15
Compare
github-actions
bot
removed
the
kernel
lemillermicrosoft
added
the
PR: ready for review
github-actions
bot
added
the
kernel
shawncal
force-pushed
the
427_plan_goal_escape
branch
2 times, most recently
from
340d702 to
9f3d76e
Compare
Added a check for empty goal in CreatePlanAsync method and threw a PlanningException with appropriate error code. Wrapped the plan parsing logic in a try-catch block and re-threw any exceptions as PlanningExceptions with a different error code. This improves the robustness and usability of the SequentialPlanner class.
shawncal
force-pushed
the
427_plan_goal_escape
branch
from
63b335d to
ad174a8
Compare
shawncal
approved these changes
Apr 28, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
Added a check for empty goal in CreatePlanAsync method and threw a PlanningException with appropriate error code. Wrapped the plan parsing logic in a try-catch block and re-threw any exceptions as PlanningExceptions with a different error code. This improves the robustness and usability of the SequentialPlanner class.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…crosoft#707) Added a check for empty goal in CreatePlanAsync method and threw a PlanningException with appropriate error code. Wrapped the plan parsing logic in a try-catch block and re-threw any exceptions as PlanningExceptions with a different error code. This improves the robustness and usability of the SequentialPlanner class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for empty goal in CreatePlanAsync method and threw a PlanningException with appropriate error code. Wrapped the plan parsing logic in a try-catch block and re-threw any exceptions as PlanningExceptions with a different error code. This improves the robustness and usability of the SequentialPlanner class.
Contribution Checklist
dotnet format