-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Python: Introducing Vector Search to Weaviate and adding the ability to have unnamed vectors #9684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:weaviate_search
Nov 15, 2024
Merged
Python: Introducing Vector Search to Weaviate and adding the ability to have unnamed vectors #9684
eavanvalkenburg
merged 4 commits into
microsoft:main
from
eavanvalkenburg:weaviate_search
Nov 15, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1113161
to
f72e542
Compare
TaoChenOSU
reviewed
Nov 13, 2024
python/semantic_kernel/connectors/memory/weaviate/weaviate_collection.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/weaviate/weaviate_collection.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/weaviate/weaviate_collection.py
Outdated
Show resolved
Hide resolved
28d4d25
to
7161437
Compare
TaoChenOSU
approved these changes
Nov 14, 2024
alliscode
approved these changes
Nov 14, 2024
7161437
to
a1a4032
Compare
markwallace-microsoft
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
memory
PR: breaking change
Pull requests that introduce breaking changes
python
Pull requests for the Python Semantic Kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds vector search to Weaviate.
All three types of search are supported, however vectorizable_text_search depends on a setup outside SK.
Also adds a parameter to the Weaviate Collection called 'named_vectors', default is True.
When set to False it uses unnamed vectors instead of named.
Because of this there is a slight difference in how vectors are represented to Weaviate which might be breaking.
Description
The breaking change is that, vector were set to have the name of the content that it vectorized, for instance:
With a datamodel like this (shortened some of the class names):
This would be set as
DataObject(vector: {"content": [vector content]})
, while it will now set this toDataObject(vector: {"vector": [vector content]})
Where DataObject is the Weaviate object used to insert items.Closes #6839
Contribution Checklist