Fix UsingTask order for VS 17.12 #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://learn.microsoft.com/en-us/visualstudio/msbuild/usingtask-element-msbuild?view=vs-2022: > Unlike properties and items, the first `UsingTask` element that applies to a > `TaskName` will be used; to override tasks you must define a new `UsingTask` > before the existing one, or specify `Override="true"` in the new `UsingTask`. Therefore when using Visual Studio 17.12 .NET 8 was picked instead of .NET 9, as the task/condition for .NET 8 also matched and came first. This was broken in a69773a, before that, the conditions had upper bounds.
mruxmohan4
approved these changes
Jan 22, 2025
|
Thank you for catching and resolving this issue! |
|
@mruxmohan4 thank you for merging this so quickly. Would you mind making a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSBuild task is currently not working, and fails with runtime errors.
As per
https://learn.microsoft.com/en-us/visualstudio/msbuild/usingtask-element-msbuild?view=vs-2022:
Therefore when using Visual Studio 17.12, .NET 8 was picked instead of .NET 9, as the task/condition for .NET 8 also matched and came first.
This was broken in a69773a, before that, the conditions had upper bounds.