Skip to content

Commit a7533fa

Browse files
committed
eh these events are from pane content anyways!
1 parent 052dc78 commit a7533fa

File tree

3 files changed

+16
-19
lines changed

3 files changed

+16
-19
lines changed

src/cascadia/TerminalApp/IPaneContent.idl

+7-7
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ namespace TerminalApp
2626

2727
void Close();
2828

29-
event Windows.Foundation.TypedEventHandler<Object, Object> CloseRequested;
29+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> CloseRequested;
3030

31-
event Windows.Foundation.TypedEventHandler<Object, BellEventArgs> BellRequested;
32-
event Windows.Foundation.TypedEventHandler<Object, Object> TitleChanged;
33-
event Windows.Foundation.TypedEventHandler<Object, Object> TabColorChanged;
34-
event Windows.Foundation.TypedEventHandler<Object, Object> TaskbarProgressChanged;
3531
event Windows.Foundation.TypedEventHandler<Object, Object> ConnectionStateChanged;
36-
event Windows.Foundation.TypedEventHandler<Object, Object> ReadOnlyChanged;
37-
event Windows.Foundation.TypedEventHandler<Object, Object> FocusRequested;
32+
event Windows.Foundation.TypedEventHandler<IPaneContent, BellEventArgs> BellRequested;
33+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> TitleChanged;
34+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> TabColorChanged;
35+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> TaskbarProgressChanged;
36+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> ReadOnlyChanged;
37+
event Windows.Foundation.TypedEventHandler<IPaneContent, Object> FocusRequested;
3838
};
3939

4040

src/cascadia/TerminalApp/TerminalPaneContent.h

+7-7
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ namespace winrt::TerminalApp::implementation
4848
Windows::Foundation::Size GridUnitSize();
4949

5050
til::typed_event<TerminalApp::TerminalPaneContent, winrt::Windows::Foundation::IInspectable> RestartTerminalRequested;
51-
til::typed_event<> CloseRequested;
52-
til::typed_event<winrt::Windows::Foundation::IInspectable, winrt::TerminalApp::BellEventArgs> BellRequested;
53-
til::typed_event<> TitleChanged;
54-
til::typed_event<> TabColorChanged;
55-
til::typed_event<> TaskbarProgressChanged;
5651
til::typed_event<> ConnectionStateChanged;
57-
til::typed_event<> ReadOnlyChanged;
58-
til::typed_event<> FocusRequested;
52+
til::typed_event<IPaneContent> CloseRequested;
53+
til::typed_event<IPaneContent, winrt::TerminalApp::BellEventArgs> BellRequested;
54+
til::typed_event<IPaneContent> TitleChanged;
55+
til::typed_event<IPaneContent> TabColorChanged;
56+
til::typed_event<IPaneContent> TaskbarProgressChanged;
57+
til::typed_event<IPaneContent> ReadOnlyChanged;
58+
til::typed_event<IPaneContent> FocusRequested;
5959

6060
private:
6161
winrt::Microsoft::Terminal::Control::TermControl _control{ nullptr };

src/cascadia/TerminalApp/TerminalTab.cpp

+2-5
Original file line numberDiff line numberDiff line change
@@ -1021,17 +1021,14 @@ namespace winrt::TerminalApp::implementation
10211021

10221022
events.FocusRequested = content.FocusRequested(
10231023
winrt::auto_revoke,
1024-
[dispatcher, weakThis](auto sender, auto) -> winrt::fire_and_forget {
1024+
[dispatcher, weakThis](TerminalApp::IPaneContent sender, auto) -> winrt::fire_and_forget {
10251025
const auto weakThisCopy = weakThis;
10261026
co_await wil::resume_foreground(dispatcher);
10271027
if (const auto tab{ weakThisCopy.get() })
10281028
{
10291029
if (tab->_focused())
10301030
{
1031-
if (const auto content{ sender.try_as<TerminalApp::IPaneContent>() })
1032-
{
1033-
content.Focus(FocusState::Pointer);
1034-
}
1031+
sender.Focus(FocusState::Pointer);
10351032
}
10361033
}
10371034
});

0 commit comments

Comments
 (0)