Skip to content

[Settings - Line Height] : Label 'Line Height' is not associated with the 'Reset' button. #15158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Saiteja341 opened this issue Apr 11, 2023 · 0 comments · Fixed by #15756
Closed

[Settings - Line Height] : Label 'Line Height' is not associated with the 'Reset' button. #15158

Saiteja341 opened this issue Apr 11, 2023 · 0 comments · Fixed by #15756
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Milestone
Terminal v1.19

Comments

@Saiteja341
Copy link

Saiteja341 commented Apr 11, 2023 •
edited
Loading

Windows Terminal version

1.18.902.0

Windows build number

25324.1011

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 25324.1011)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

1.Open Windows Terminal.
2.Open Setting page using 'Ctrl + ,' keys.
3.Now navigate to the 'Advanced' button present under 'Default Profile'.
4. Now navigate to the 'Line Height's reset' button and observe the issue.

User Experience:
People with visual impairments who rely on the screen readers are unable to know the button's description.

Guideline Link:
https://www.w3.org/TR/WCAG21/#info-and-relationships

Attachments:
Label 'Line Height' is not associated with the 'Reset' button..zip

Expected Behavior

Label 'Line Height' should be associated with the 'Reset' button.

Actual Behavior

Label 'Line Height' is not associated with the 'Reset' button.
@Saiteja341 Saiteja341 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 11, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Apr 11, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Apr 13, 2023
@carlos-zamora carlos-zamora mentioned this issue Jul 24, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jul 24, 2023
carlos-zamora added a commit that referenced this issue Jul 25, 2023
@carlos-zamora
Add UIA element grouping to SettingsContainer (#15756)
d70794a 
Adds an `AutomationProperty.Name` to the main grid in the `SettingContainer`. Doing so makes it so that the group of elements is considered a "group \<header\>".

Now, when navigating with a screen reader, when you enter the group of elements, the "group \<header\>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group \<header\>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice.

Closes #15158
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 25, 2023
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Add UIA element grouping to SettingsContainer (#15756)
3edbcf9 
Adds an `AutomationProperty.Name` to the main grid in the `SettingContainer`. Doing so makes it so that the group of elements is considered a "group \<header\>".

Now, when navigating with a screen reader, when you enter the group of elements, the "group \<header\>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group \<header\>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice.

Closes #15158

(cherry picked from commit d70794a)
Service-Card-Id: 89990838
Service-Version: 1.17
DHowett pushed a commit that referenced this issue Jul 27, 2023
@carlos-zamora @DHowett
Add UIA element grouping to SettingsContainer (#15756)
dec1974 
Adds an `AutomationProperty.Name` to the main grid in the `SettingContainer`. Doing so makes it so that the group of elements is considered a "group \<header\>".

Now, when navigating with a screen reader, when you enter the group of elements, the "group \<header\>" will be presented. Thus, if the user navigates to the "reset" button, it'll be prefaced with a "group \<header\>" announcement first. If the user navigates to it from the other direction (the setting control), this announcement isn't made, but the user already has an understanding of what group of settings they're in, which is standard practice.

Closes #15158

(cherry picked from commit d70794a)
Service-Card-Id: 89990839
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Milestone
Terminal v1.19
Development

Successfully merging a pull request may close this issue.

Add UIA element grouping to SettingsContainer microsoft/terminal
3 participants
@zadjii-msft @Priyanka-Chauhan123 @Saiteja341