Skip to content

"Open Terminal here" doesn't show a window on 1.18 #15193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zadjii-msft opened this issue Apr 17, 2023 · 3 comments · Fixed by #13838
Closed

"Open Terminal here" doesn't show a window on 1.18 #15193

zadjii-msft opened this issue Apr 17, 2023 · 3 comments · Fixed by #13838
Labels
Area-ShellExtension For issues related to the explorer right-click context menu In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@zadjii-msft
Copy link
Member

Probably regressed in #13838, though following up with Leonard on which build he's on specifically.

On my dev/lhecker/14957-fix-resize-glitch current dev build, I can't repro it
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-1 A description (P1) Area-ShellExtension For issues related to the explorer right-click context menu labels Apr 17, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Apr 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 17, 2023
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 17, 2023
zadjii-msft added a commit that referenced this issue Apr 17, 2023
@zadjii-msft
Always show from explorer. Closes #15193
03c1430
@zadjii-msft zadjii-msft mentioned this issue Apr 17, 2023
Merged
@xyang-zh
Copy link

Probably regressed in #13838, though following up with Leonard on which build he's on specifically.

On my dev/lhecker/14957-fix-resize-glitch current dev build, I can't repro it

I have another question, please answer it for me if you can：
Why can't I change the display language of the windows terminal compiled with visual studio 2022, even though I have chosen another language and restarted windows terminal, it is still in the same language

@zadjii-msft
Copy link
Member Author

I'm not sure the Dev builds of the Terminal have all the localization infrastructure built in. The different translations all come from another service and get stitched in in the actual Release CI, if I recall correctly

@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 18, 2023
microsoft-github-policy-service bot pushed a commit that referenced this issue Apr 18, 2023
@zadjii-msft @DHowett
Respect the startup info state initially passed to wt via ShellExec…
2c16e7c 
…ute (#13838)

Original description, pre-process model v3:

> This is just the `SHOWDEFAULT` bit from #12979. This seems to also
work now, but I'm PR'ing it separately so it can be a separate revert
from #13811, if it is problematic.

More accurately: 
This PR enables terminal windows to use the `wShowCmd` from the
STARTUPINFO passed to `windowsterminal.exe` to set the initial
visibility of the window. We can't just use `SW_SHOWDEFAULT`, because
all the windows are running in the initial process! After the first
window, the subsequent ones would ignore any params passed to their
originating `windowsterminal.exe` processes. To mitigate, we pass that
`wShowCmd` info from the source process, to the actual running terminal
process. That accounts for most of the delta here.

Closes #9053


This doesn't do the same for defterm-initiated connections. This is
because we don't need to! Defterm very explicitly rejects handoff for
minimized console apps. This is probably for the best! I put an attempt
in 66f8b25 before I forgot that it was filtered long before the
Terminal. NOT doing this for /min saves us all sorts of "what happens if
`start /min cmd` tries to glom?" or "what if someone does `start /min
cmd && start /max cmd` and they glom together?".

<hr>

Also closes #15193, which was introduced as a part of this.

---------

Co-authored-by: Dustin L. Howett <[email protected]>
@xyang-zh
Copy link

I'm not sure the Dev builds of the Terminal have all the localization infrastructure built in. The different translations all come from another service and get stitched in in the actual Release CI, if I recall correctly

Well, it looks like I've learned something new, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ShellExtension For issues related to the explorer right-click context menu In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Respect the startup info state initially passed to wt via ShellExecute microsoft/terminal
2 participants
@zadjii-msft @xyang-zh