Skip to content

Make reset button accessible #15257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BenConstable9
Copy link
Contributor

@BenConstable9 BenConstable9 commented Apr 28, 2023

Make the reset button accessible by adding description in reset.

Closes #12044

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 28, 2023
@zadjii-msft
Copy link
Member

Hmm, is there a way that we could perhaps only set a tooltip, or some other a11y hint? Changing this string to be longer does cause the flyout to be quite a bit... chonkier:

image

@carlos-zamora might have some ideas on UIA properties that might be suitable here.

@BenConstable9
Copy link
Contributor Author

Hmm, is there a way that we could perhaps only set a tooltip, or some other a11y hint? Changing this string to be longer does cause the flyout to be quite a bit... chonkier:

image

@carlos-zamora might have some ideas on UIA properties that might be suitable here.

No problem, I will add an automation property on it to make it still say Reset and instead another for a screen reader.

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@DHowett DHowett changed the title Make reset button accessible. Make reset button accessible Apr 28, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone May 1, 2023
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Narrator and NVDA

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 2, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6abd721 into microsoft:main May 2, 2023
DHowett added a commit that referenced this pull request May 15, 2023
Make the reset button accessible by adding description in reset.

Closes #12044

---------

Co-authored-by: Dustin L. Howett <[email protected]>
(cherry picked from commit 6abd721)
Service-Card-Id: 89047231
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Terminal >Set tab color]: Accessible name is not descriptive for 'Reset' button.
5 participants