Remove boolean success return values from TextBuffer #15566
Merged
+178
−269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
lhecker
commented
Jun 16, 2023
| @@ -435,10 +435,9 @@ OutputCellIterator ROW::WriteCells(OutputCellIterator it, const til::CoordType c | |||
| return it; | |||
| } | |||
|
|
|||
| bool ROW::SetAttrToEnd(const til::CoordType columnBegin, const TextAttribute attr) | |||
There was a problem hiding this comment.
Suppressing whitespace changes is required: https://github.com/microsoft/terminal/pull/15566/files?w=1
Practically nothing of substance changed in this PR. 🙂
DHowett
approved these changes
Jun 16, 2023
Comment on lines
-2695
to
-2701
| if (!newBuffer.IncrementCursor()) | ||
| { | ||
| hr = E_OUTOFMEMORY; | ||
| break; | ||
| } | ||
| } | ||
| } |
carlos-zamora
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed these because it made some of my new code pretty
convoluted for now good reason as most of these functions aren't
exception safe to begin with. Basically, their boolean status
is often just a pretense because they can crash or throw anyways.
Furthermore,
WriteCharsLegacyfailed to check the status codereturned by
AdjustCursorPositionin some of its parts too.In the future we should instead probably strive to continue
make our legacy code more exception safe.