-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Add prompt to choose between opening JSON settings file or folder #19059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add prompt to choose between opening JSON settings file or folder #19059
Conversation
@farheen-shaikh530 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
My thoughts: Why a content dialog and not a button with secondary conmand? A button with secondary command to open the folder feels much user friendlier. |
af2ff44
to
d35ec59
Compare
Hi team, I've cleaned up the PR and removed unrelated |
Thank you for the feedback! |
Summary of the Pull Request
This PR introduces a confirmation dialog that allows users to choose between opening the settings JSON file or the containing folder. This enhances user flexibility when accessing configuration files from the terminal.
Motivation
Previously, clicking "Open JSON" would directly open the file. This change adds user choice, improving usability and matching expectations for broader editing or navigation workflows.
References and Relevant Issues
Fixes #14410
Marked as [Good First Issue] in the Microsoft Terminal GitHub repository.
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Contributor License Agreement
@microsoft-github-policy-service agree
I confirm that I am submitting this contribution as an individual, and I own the rights to this code. I am not submitting on behalf of an employer or organization.
PR Checklist