Add a spec for #7335, "console allocation policy"

.github/actions/spell-check/expect/expect.txt

@@ -413,6 +413,7 @@ crt
 CRTLIBS
 csbi
 csbiex
+cscript
 csharp
 CSHORT
 cso
@@ -442,6 +443,7 @@ Ctx
 Ctxt
 ctype
 CUF
+CUI
 cupxy
 curated
 CURRENTFONT
@@ -1331,6 +1333,7 @@ lstrcmp
 LTEXT
 LTLTLTLTL
 ltype
+Lua
 LUID
 lval
 LVB
@@ -1717,6 +1720,8 @@ pdx
 peb
 PEMAGIC
 PENDTASKMSG
+perl
+perlw
 pfa
 PFACENODE
 pfed
@@ -1869,6 +1874,7 @@ PWCHAR
 PWDDMCONSOLECONTEXT
 PWORD
 pwsh
+pwshw
 pwstr
 pwsz
 px
@@ -2010,6 +2016,7 @@ Rtl
 RTLREADING
 RTTI
 ru
+rubyw
 ruleset
 runas
 runasradio
@@ -2438,6 +2445,7 @@ UCHAR
 ucs
 UDKs
 UDM
+uefi
 uer
 uget
 uia

doc/specs/#7335 - Console Allocation Policy.md

@@ -0,0 +1,202 @@
+---
+author: Dustin Howett @DHowett <[email protected]>
+created on: 2020-08-16
+last updated: 2020-08-18
+issue id: \#7335
+---
+
+# Console Allocation Policy
+
+## Abstract
+
+Due to the design of the console subsystem on Windows as it has existed since Windows 95, every application that is
+stamped with the `IMAGE_SUBSYSTEM_WINDOWS_CUI` subsystem in its PE header will be allocated a console by kernel32.
+
+Any application that is stamped `IMAGE_SUBSYSTEM_WINDOWS_GUI` will not automatically be allocated a console.
+
+This has worked fine for many years: when you double-click a console application in your GUI shell, it is allocated a
+console.  When you run a GUI application from your console shell, it is **not** allocated a console. The shell will
+**not** wait for it to exit before returning you to a prompt.
+
+There is a large class of applications that has diverse console allocation needs. Take Python (or perhaps Perl, Ruby, or
+Lua, or even our own VBScript). People author GUI applications in Python and Perl and VBScript, for better or for worse.
+
+Because they are console subsystem applications, any user double-clicking a shortcut to a Python or Perl application
+will be presented with a useless black box that the language runtime may choose to garbage collect, or may choose not
+to.
+
+Any user running that GUI application from a console shell will see their shell hang until the application terminates.
+
+All of these scripting languages worked around this by shipping two binaries each, identical in every way expect in
+their subsystem bits. python/pythonw, perl/perlw, ruby/rubyw, wscript/cscript.
+
+Likewise, PowerShell\[1\] is waiting to deal with this problem because they don't necessarily want to ship a `pwshw.exe`
+for all of their GUI-only authors.
+
+On the other side, you have mostly-GUI applications that want to print output to a console **if there is one
+connected**.  Sometimes they'll allocate their own (and therefore a new window) to display in, and sometimes they'll
+reattach to the one they could have inherited. VSCode does the latter, and so when you run `code` from CMD, and then
+`exit` CMD, your console window sticks around because VSCode is still attached to it. It will never print anything, so
+you just have a dead console window.
+
+There's a risk in reattaching, though. Given that the shell decides whether to wait based on the subsystem field, GUI
+subsystem applications that reattach to their owning consoles *just to print some text* end up stomping on the output of
+any shell that doesn't wait for them:
+
+```
+C:\> wt --help
+
+wt - the Windows Terminal
+C:\> Usage: [OPTIONS] ...
+```
+
+> _(the prompt is interleaved with the output)_
+
+## Solution Design
+
+I propose that we introduce a fusion manifest field, **consoleAllocationPolicy**, with the following values:
+
+* `inheritOnly`
+* `always`
+
+It would look (roughly) like this:
+
+```xml
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+  <application>
+    <windowsSettings>
+      <consoleAllocationPolicy xmlns="http://schemas.microsoft.com/SMI/20XX/WindowsSettings">inheritOnly</consoleAllocationPolicy>
+    </windowsSettings>
+  </application>
+</assembly>
+```
+
+This field will apply consistent behavior across different image subsystems, with differing end user results:
+
+| policy        | `SUBSYSTEM_CUI` (console)                                             | `SUBSYSTEM_GUI` (windows)              |
+| -             | -                                                                     | -                                      |
+| _no value_    | _default behavior_                                                    | _default behavior_                     |
+| `inheritOnly` | No console window unless application was started from console session | No console window (_default behavior_) |
+| `always`      | Always opens a console window (_default behavior_)                    | Always opens a console window          |
+
+An application that is in the *console* subsystem with a `consoleAllocationPolicy` of **inheritOnly** will not present a
+console when launched from Explorer.
+
+An application that is in the *windows* subsystem with a `consoleAllocationPolicy` of **always** *will always* be
+allocated a new conhost on startup.
+
+## Inspiration
+
+Fusion manifest entries are used to make application-scoped decisions like this all the time, like `longPathAware` and
+`heapType`.
+
+CUI applications that can spawn a UI (or GUI applications that can print to a console) are commonplace on other
+platforms because there is no subsystem differentiation.
+
+## UI/UX Design
+
+There is no UI for this feature.
+
+## Capabilities
+
+### Accessibility
+
+This should have no impact on accessibility.
+
+### Security
+
+One reviewer brought up the potential for a malicious actor to spawn an endless stream of headless daemon processes.
+
+This proposal in no way changes the facilities available to malicious people for causing harm: they could have simply
+used `IMAGE_SUBSYSTEM_WINDOWS_GUI` and not presented a UI--an option that has been available to them for 35 years.
+
+### Reliability
+
+This should have no impact on reliability.
+
+### Compatibility
+
+On downlevel versions of Windows that do not understand (or expect) this manifest field, applications will allocate
+consoles as specified by their image subsystem (described in the [abstract](#abstract) above).
+
+An existing application opting into **inheritOnly** may constitute a breaking change, but the scope of the breakage is
+restricted to that application and is expected to be managed by the application.
+
+All behavioral changes are opt-in.
+
+> **EXAMPLE**: If Python updates python.exe to specify an allocation policy of **inheritOnly**, graphical python
+> applications will become double-click runnable from the graphical shell without spawning a console window. _However_,
+> console-based python applications will no longer spawn a console window when double-clicked from the graphical shell.
+
+Python could work around this by calling [`AllocConsole`] if it can be detected that console I/O is required.
+
+### Performance, Power, and Efficiency
+
+This should have no impact on performance, power or efficiency.
+
+## Potential Issues
+
+### Shell Hang
+
+I am **not** proposing a change in how shells determine whether to wait for an application before returning to a prompt.
+This means that a console subsystem application that intends to primarily present a UI but occasionally print text to a
+console (therefore choosing the **inheritOnly** allocation policy) will cause the shell to "hang" and wait for it to
+exit.
+
+Because the vast majority of shells on Windows "hang" by calling `WaitFor...Object` with a HANDLE to the spawned
+process, an application that wants to be a "hybrid" CUI/GUI application will be forced to spawn a separate process to
+detach from the shell and then terminate its main process.
+
+This is very similar to the forking model seen in many POSIX-compliant operating systems.
+
+### Launching interactively from Explorer
+
+Applications like PowerShell may wish to retain "automatic" console allocation, and **inheritOnly** would be unsuitable
+for them. If PowerShell becomes **inheritOnly**, double-clicking `pwsh.exe` will no longer spawn a console. This would
+be a critical failure of the console subsystem.
+
+At the same time, PowerShell wants `-WindowStyle Hidden` to suppress the console _before it's created_.
+
+PowerShell, and any other shell that wishes to maintain interactive launch from the graphical shell, will need to call
+[`AllocConsole`] if it determines that it wants to launch in interactive mode.
+
+## Future considerations
+
+We're introducing a new manifest field today -- what if we want to introduce more? Should we have a `consoleSettings`
+manifest block?
+
+Are there other allocation policies we need to consider?
+
+## Resources
+
+### Rejected Solutions
+
+- A new PE subsystem, `IMAGE_SUBSYSTEM_WINDOWS_HYBRID`
+    - it would behave like **inheritOnly**
+    - relies on shells to update and check for this
+    - checking a subsystem doesn't work right with app execution aliases\[2\]
+        - This is not a new problem, but it digs the hole a little deeper.
+    - requires standardization outside of Microsoft because the PE format is a dependency of the UEFI specification\[3\]
+    - requires coordination between tooling teams both within and without Microsoft
+        - VC's `link`
+        - binutils' `ld`
+        - LLVM's `llvm-ld` (`lld`)
+        - Any number of binary analysis toolkits
+
+- An exported symbol that shells can check for to determine whether to wait for the attached process to exit
+    - relies on shells to update and check for this
+    - cracking an executable to look for symbols is probably the last thing shells want to do
+        - we could provide an API to determine whether to wait or return?
+    - fragile, somewhat silly, exporting symbols from EXEs is annoying and uncommon
+
+### Links
+
+1. [Powershell -WindowStyle Hidden still shows a window briefly]
+2. [PowerShell: Windows Store applications incorrectly assumed to be console applications]
+3. [UEFI spec 2.6 appendix Q.1]
+
+[Powershell -WindowStyle Hidden still shows a window briefly]: https://github.com/PowerShell/PowerShell/issues/3028
+[PowerShell: Windows Store applications incorrectly assumed to be console applications]: https://github.com/PowerShell/PowerShell/issues/9970
+[UEFI spec 2.6 appendix Q.1]: https://www.uefi.org/sites/default/files/resources/UEFI%20Spec%202_6.pdf
+[`AllocConsole`]: https://docs.microsoft.com/windows/console/allocconsole