-
Notifications
You must be signed in to change notification settings - Fork 273
remove redudnant cast to IReadOnlyList and add a not null ckeck in AssemblyEnumeratorTests #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…semblyEnumeratorTests
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
|
||
Verify(types is not null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assert is failing. It's because the mocking two lines above is throwing ReflectionTypeLoadException
passing null array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: The failure is .NET Framework only, due to difference in ReflectionTypeLoadException
implementation between .NET Core and .NET Framework.
When the constructor in .NET Core receives null, it sets the property to empty array:
This is not the case for .NET Framework.
…dd-a-not-null-ckeck-in-AssemblyEnumeratorTests
…semblyEnumeratorTests