-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add shortTitle to execSelectionInTerminal command #25007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add shortTitle to execSelectionInTerminal command #25007
Conversation
@Dinesh-0813 Can you remove the package.lock. it might be using the wrong version of npm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package bump / package-lock.json changes should not be committed this way
package.json
Outdated
@@ -1567,7 +1569,7 @@ | |||
"cross-env": "^7.0.3", | |||
"cross-spawn": "^6.0.5", | |||
"del": "^6.0.0", | |||
"download": "^8.0.0", | |||
"download": "^3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo this version change, and revert the package-lock.json
@microsoft-github-policy-service agree |
Hi, I've reverted the package-lock.json and package.json changes as requested. Please review again. Thank you! |
You will still want to keep the title addition in package.json, just without the module version bump |
Hi, I’ve added the title field back to package.json as %shortTitle% without modifying the version. Let me know if anything else is needed. Thanks! |
package.json
Outdated
@@ -2,6 +2,7 @@ | |||
"name": "python", | |||
"displayName": "Python", | |||
"description": "Python language support with extension access points for IntelliSense (Pylance), Debugging (Python Debugger), linting, formatting, refactoring, unit tests, and more.", | |||
"title": "%shortTitle%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should really be on the command not the extension.
Thanks for the feedback! I've moved the shortTitle to the command as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Hi @connor4312 @karthiknadig, I have fixed the missing shortTitle in package.nls.json as suggested. Kindly review. Thanks!"
@@ -325,7 +325,8 @@ | |||
{ | |||
"category": "Python", | |||
"command": "python.execSelectionInTerminal", | |||
"title": "%python.command.python.execSelectionInTerminal.title%" | |||
"title": "%python.command.python.execSelectionInTerminal.title%", | |||
"shortTitle": "%python.menu.execSelectionInTerminal.title%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be python.command.python.execSelectionInTerminal.shortTitle
hi iam a begineer from tamilnadu if i do anything wrong please let me know
thankyou!
Add shortTitle to execSelectionInTerminal command