Introduce Sound Theme, similar like Product Icon Themes

[isidorn]

Some users want more customisation towards what sounds are being used.
I think in the future we should consider introducing Sound Themes similar to Icon Themes. So they can be extensions and users can choose which one is applied.

For now assigning this to the backlog.
fyi @aeschli @hediet

@gino-scarpino to try out the product icon experience do F1 > Preferences Product Icon Themes > Browse Additional Product Icon Themes...

[hediet]

Interesting idea.
Shouldn't we start with overridable audio cues first though? (the same as users can override specific theme colors)

[isidorn]

@hediet but the theme color you can specify inside the settings.json, for sounds it would have to be a path to the audio file which is in opus format. Which I find ugly. I just thought that the Theme would be the "best packaged" solution. Same as how we do not allow specific overrides for product icon themes.

[miguelsolorio]

This seems like a natural progression from our customization options and extension API 👍

though I do imagine seeing this a bigger hurdle for extension authors as it requires some knowledge of generating/constructing audio sounds (similar to product icon themes requiring icon design). but from a principle, this makes a lot of sense.

[gino-scarpino]

Sorry, clarifying question, are we saying you'd like to light up the ability for the community to create and implement their own sounds? I know I'm new to the VS Code mindset, but this sounds like a crazy, out of control idea to me and I'd need to be convinced as to how, for sound, this would end in anything but cacophony. Thanks, G

…

________________________________ From: Miguel Solorio ***@***.***> Sent: Wednesday, March 16, 2022 10:37 AM To: microsoft/vscode ***@***.***> Cc: Gino Scarpino ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/vscode] Introduce Sound Theme, similar like Product Icon Themes (Issue #145204) This seems like a natural progression from our customization options and extension API 👍 though I do imagine seeing this a bigger hurdle for extension authors as it requires some knowledge of generating/constructing audio sounds (similar to product icon themes requiring icon design). but from a principle, this makes a lot of sense. — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.jpy.wang%2Fmicrosoft%2Fvscode%2Fissues%2F145204%23issuecomment-1069387905&data=04%7C01%7Cginoscarpino%40microsoft.com%7C523e80dd1ca1404e9af908da0773a5c9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637830490534876262%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BSkOM1HWdroB6WmaukkqhymusWNo7NZ2s22xvudGUAo%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.jpy.wang%2Fnotifications%2Funsubscribe-auth%2FAWWW7HV6ROPW4LTP5FWTTBLVAIL5VANCNFSM5Q3PLFQA&data=04%7C01%7Cginoscarpino%40microsoft.com%7C523e80dd1ca1404e9af908da0773a5c9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637830490534876262%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=SoC0IitNmWXQpNdoqXMAQakWnDYBESuTF8qhiIGFHL8%3D&reserved=0>. Triage notifications on the go with GitHub Mobile for iOS<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cginoscarpino%40microsoft.com%7C523e80dd1ca1404e9af908da0773a5c9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637830490534926266%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=I3lbjMoKZg06FahzTeh7%2F8r3OxUI0lYPf88Un19UDho%3D&reserved=0> or Android<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cginoscarpino%40microsoft.com%7C523e80dd1ca1404e9af908da0773a5c9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637830490534926266%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=J5Yogo%2Bdhgt2RxaDfRUZ4xoNZgeI%2FSZgZmOkOITJFKQ%3D&reserved=0>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[miguelsolorio]

@gino-scarpino essentially, yes. This is one of the differentiators of the product where you can customize nearly everything: color themes, settings, icon themes. While it may sound like a crazy idea at first, this really opens the door for others to push the boundaries and give users more options. I initially wasn't a fan of it for product icon themes but this has made it possible for others to find the right customizations that fit their own workflow (see these product icon theme extensions that have started within the last year).

[MarximusMaximus]

This seems like a natural progression from our customization options and extension API 👍

though I do imagine seeing this a bigger hurdle for extension authors as it requires some knowledge of generating/constructing audio sounds (similar to product icon themes requiring icon design). but from a principle, this makes a lot of sense.

Could you elaborate/link any docs where I could get started on just overriding the default sounds?

The breakpoint sound is making a weird clicking in my left ear and it's really annoying. It is more pronounced in the left channel, although it is still there in the right channel (swapped headphone ears to check). It is right at the end of the sound. Gets very pronounced if you're hitting breakpoint after breakpoint quickly.

[miguelsolorio]

Could you elaborate/link any docs where I could get started on just overriding the default sounds?

This is not currently possible and is why this issue remains open on the backlog. If you are encountering any audio issues, please create a new issue for us to take a look at. Thanks!

[AFre100]

Hi @MarximusMaximus,

cc @gino-scarpino

I'm a sound designer working for Microsoft. Thanks for bringing this to our attention! Sounds like some friction -- this issue is not taken lightly.

I've included some potential fixes below and information asks from your end to help us zero in on this for yourself and other users.

Please download and test/play these (very short) audio files in Media Player. The link will expire in the near future
Can you indicate the amount of “click” you hear in each, if any?

Troubleshooting

• I know that you know this, but just wanted to triple check that this problem persists after restarting your computer?

• Hardware, out of date drivers, high CPU, and a few other culprits are common causes for popping and crackling in Windows 10 & 11. A few links below have troubleshooting exercises while will help you solve the issue or isolate it -- does it still persist?

The Geek Page
Winbuzzer
MS Community Forum

• Which machine, OS, version of VS Code are you running while experiencing this issue?

• Are headphones plugged in directly to the computer? If not, what hardware is it plugged into (e.g. display monitor, audio interface, HDMI device, etc)?

If the problem is still persisting:
• Any audio of the "click" you can capture would be helpful. Can you please provide a screen grab or recording of it happening? If that's difficult to do, even a cell phone video recording would be better than nothing if it's audible.