Skip to content

Minor fix for drawer swipe #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Minor fix for drawer swipe #979

merged 3 commits into from
Mar 4, 2021

Conversation

RobbWatershed
Copy link
Contributor

@RobbWatershed RobbWatershed commented Feb 24, 2021

  • Use item unique IDs instead of positions to keep track of swiped states (positions would become meaningless as soon as items are added or removed from the list)
  • Don't transmit touch events to target items that are not in swiped state

NB : These changes fix a weird behaviour when dragging the drag handle of a swipeable item over the drag handle of a sibling - the item would keep floating in mid-air as its UP touch event wouldn't be transmitted to the correct item

@mikepenz mikepenz self-assigned this Feb 24, 2021
@RobbWatershed
Copy link
Contributor Author

Hi there~

Any chance to get that one merged soon-ish ? ^^

@mikepenz
Copy link
Owner

mikepenz commented Mar 4, 2021

oh sorry. I'll have a look :)

@mikepenz mikepenz added the fix label Mar 4, 2021
@mikepenz mikepenz merged commit 9490e17 into mikepenz:develop Mar 4, 2021
@RobbWatershed
Copy link
Contributor Author

Great, thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants