use watch instead of polling #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itspooya
force-pushed
the
watch-feature
branch
2 times, most recently
from
802f1bc to
2a5f351
Compare
|
Hello Dear @mikkeloscar |
itspooya
force-pushed
the
watch-feature
branch
2 times, most recently
from
23f9d07 to
2b92617
Compare
|
@itspooya Thanks for the PR. I will try to review it next week. I see you added build related changes. Could you do that as a separate PR, that makes it easier to review? |
itspooya
force-pushed
the
watch-feature
branch
2 times, most recently
from
bb45257 to
e084e13
Compare
Signed-off-by: itspooya <[email protected]>
|
just a small note, it requires some changes, re review the logic and then I will ping you to review, ignore it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.